Skip to content

Commit

Permalink
[MIRROR] The Shovellening: Coroner and Miner Coats can now hold Shove…
Browse files Browse the repository at this point in the history
…ls (#2479)

* The Shovellening: Coroner and Miner Coats can now hold Shovels (#83139)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
The Shovel, Serrated Bone Shovel, and the Entrenching Tooll can now be
worn on the Coroner/Miner Winter Coats, as well as upon the Coroner's
labcoat. Normally, shovels worn on the belt slot are displayed on your
sprite at your back, and allowing them to go on the suit slot initially
mirrored them to the front on side-facing mobs.

I've changed the mirrored sprites for side-facing in the belt_mirror.dmi
in order to _not_ be mirrored, so they display properly on the back. Not
a very elegant way to do it, but this hasn't caused issues with
double-equipping shovels in testing.


![shovel_example](https://github.com/tgstation/tgstation/assets/147954468/f7258466-f4f2-4869-9302-199e76759766)
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Miner Winter Coats should be able to hold shovels as they're mining
tools to begin with, and Coroners should be able to do the same in order
to dig or dig up graves. The Serrated Shovel, as well, is the only
Morbid Bone Saw equivalent in the game as far as I know, so this would
allow Coroners to carry that Morbid equivalent without taking up bag
space. This encourages Coroners to lean further into the flavor of their
role as Morbid or Occultic Medbay personnel.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl: Jane
qol: Shovels, Serrated Bone Shovels, and Entrenching Tools can now be
hung upon Miner and Coroner Winter Coats, as well as the Coroner's
Labcoat!
image: Mirrored the mirrored sprites to display Shovels in the suit slot
properly.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Ghom <[email protected]>

* The Shovellening: Coroner and Miner Coats can now hold Shovels

---------

Co-authored-by: DrAmazing343 <[email protected]>
Co-authored-by: Ghom <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
  • Loading branch information
4 people authored and StealsThePRs committed May 15, 2024
1 parent dcbe8ba commit ecababf
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions code/modules/clothing/suits/labcoat.dm
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@
allowed += list(
/obj/item/autopsy_scanner,
/obj/item/scythe,
/obj/item/shovel,
/obj/item/shovel/serrated,
/obj/item/trench_tool,
)

/obj/item/clothing/suit/toggle/labcoat/science
Expand Down
5 changes: 5 additions & 0 deletions code/modules/clothing/suits/wintercoats.dm
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
allowed += list(
/obj/item/autopsy_scanner,
/obj/item/scythe,
/obj/item/shovel,
/obj/item/shovel/serrated,
/obj/item/trench_tool,
)

/obj/item/clothing/head/hooded/winterhood/medical/coroner
Expand Down Expand Up @@ -630,6 +633,8 @@
/obj/item/storage/bag/ore,
/obj/item/t_scanner/adv_mining_scanner,
/obj/item/tank/internals,
/obj/item/shovel,
/obj/item/trench_tool,
)
armor_type = /datum/armor/wintercoat_miner
hoodtype = /obj/item/clothing/head/hooded/winterhood/miner
Expand Down
Binary file modified icons/mob/clothing/belt.dmi
Binary file not shown.
Binary file modified icons/mob/clothing/belt_mirror.dmi
Binary file not shown.

0 comments on commit ecababf

Please sign in to comment.