Skip to content

Commit

Permalink
[MIRROR] Converts ore_mined talley into only recording typepaths. (#1540
Browse files Browse the repository at this point in the history
)

* Converts ore_mined talley into only recording typepaths. (#82098)

## About The Pull Request

This Pull request makes it so that the blackbox `ore_mined` talley will
now only record the mineral stack's typepath as opposed to a 50/50 mix
of names and typepaths.

## Why It's Good For The Game

Fixes #82042. Logging should be as descriptive as possible while also
avoiding the possibility for misunderstanding, so using the typepath for
logging on the blackbox is preferred.

## Changelog

:cl:
code: Mineral logging now collects ore names more cleanly.
/:cl:

* Converts ore_mined talley into only recording typepaths.

---------

Co-authored-by: ArcaneMusic <[email protected]>
  • Loading branch information
2 people authored and StealsThePRs committed Mar 20, 2024
1 parent 8c02f0d commit f4ff8e5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion code/modules/mining/boulder_processing/boulder.dm
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
stack_trace("boulder found containing material type [picked.type] with no set ore_type")
continue
cracked_ore = new cracked_ore_type (drop_location(), quantity)
SSblackbox.record_feedback("tally", "ore_mined", quantity, cracked_ore)
SSblackbox.record_feedback("tally", "ore_mined", quantity, cracked_ore.type)

///Moves boulder contents to the drop location, and then deletes the boulder.
/obj/item/boulder/proc/break_apart()
Expand Down

0 comments on commit f4ff8e5

Please sign in to comment.