Skip to content

Commit

Permalink
[MIRROR] Removes redundant update_parallax_contents calls (#1992)
Browse files Browse the repository at this point in the history
* Removes redundant update_parallax_contents calls (#82644)

## About The Pull Request

Off shuttle move doesn't need to happen because shuttles use abstract
move which calls it anyway
Similar story for the ghost stuff, this was actually causing pretty
common double calls so we may actually get somethin out of this Oh and
something in air which is past me knifing me in the back

* Removes redundant update_parallax_contents calls

---------

Co-authored-by: LemonInTheDark <[email protected]>
  • Loading branch information
2 people authored and StealsThePRs committed Apr 15, 2024
1 parent 811c697 commit fb3c46a
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion code/_onclick/observer.dm
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
// Otherwise jump
else if(A.loc)
abstract_move(get_turf(A))
update_parallax_contents()

/mob/dead/observer/ClickOn(atom/A, params)
if(check_click_intercept(params,A))
Expand Down
1 change: 0 additions & 1 deletion code/controllers/subsystem/air.dm
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,6 @@ GLOBAL_LIST_EMPTY(colored_images)
if(!target)
return
usr.forceMove(target)
usr.update_parallax_contents()
if("toggle-freeze")
can_fire = !can_fire
return TRUE
Expand Down
3 changes: 0 additions & 3 deletions code/modules/mob/dead/observer/observer.dm
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
set_glide_size(glide_size_override)
if(NewLoc)
abstract_move(NewLoc)
update_parallax_contents()
else
var/turf/destination = get_turf(src)

Expand Down Expand Up @@ -476,7 +475,6 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
return

usr.abstract_move(pick(L))
update_parallax_contents()

/mob/dead/observer/verb/follow()
set category = "Ghost"
Expand Down Expand Up @@ -547,7 +545,6 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp

if(isturf(destination_turf))
source_mob.abstract_move(destination_turf)
source_mob.update_parallax_contents()
else
to_chat(source_mob, span_danger("This mob is not located in the game world."))

Expand Down
2 changes: 0 additions & 2 deletions code/modules/shuttle/on_move.dm
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,6 @@ All ShuttleMove procs go here
if(rotation)
shuttleRotate(rotation)

update_parallax_contents()

return TRUE

/atom/movable/proc/lateShuttleMove(turf/oldT, list/movement_force, move_dir)
Expand Down

0 comments on commit fb3c46a

Please sign in to comment.