Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds metal shelf recipe #1006

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[MIRROR] Adds metal shelf recipe #1006

merged 1 commit into from
Dec 7, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#25468

About The Pull Request

Adds metal shelf recipe. Have a single iron sheet in hand, pull up the menu and craft. Can still be deconstructed with a wrench.

EDIT: Changed recipe from 2 sheets to 1 because it deconstructs into rack parts which is 1 sheet.

How This Contributes To The Skyrat Roleplay Experience

This sprite has only been accessible to mappers for months, I don't know why this wasn't done sooner since it's just one line of code, but better now than never at all.

Proof of Testing

metalshelf

Changelog

🆑 Lutowski
add: You can now craft metal shelves with iron sheets.
/:cl:

* adds metal shelf recipe

* 2 iron to 1 because it deconstructs into rack parts
@Iajret Iajret merged commit 62e9758 into master Dec 7, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25468 branch December 7, 2023 11:17
AnywayFarus added a commit that referenced this pull request Dec 7, 2023
Iajret pushed a commit that referenced this pull request Feb 17, 2024
…tely (#1006)

* Spawners menu now displays the amount of uses left appropriately (#81496)

## About The Pull Request
Prior to this PR, if an individual spawner allowed more than one uses,
it would still display as one use in the menu. Not only that, but
infinite spawners would also show as having just one use. Both of these
behaviors have been fixed, resulting in a much more accurate depiction
of how many uses are left on each spawner.


![image](https://github.com/tgstation/tgstation/assets/58045821/77508cdd-66bf-4d85-9dd7-c25f8ccd41b6)
(The first spawner isn't normally infinite, I just used VV to edit its
`infinite_uses` to `1` for the sake of proving that the display worked).


## Why It's Good For The Game
Being able to know that a spawner is infinite is a good thing for
players, just like being able to know how many uses are left if an
individual spawner can be used by more than one player.

## Changelog

:cl: GoldenAlpharex
fix: The Spawners menu now accurately displays the amount of uses left
in each spawner option, taking into account individual spawners that
either allow more than one use, or an infinite amount of uses.
/:cl:

* Spawners menu now displays the amount of uses left appropriately

---------

Co-authored-by: GoldenAlpharex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants