[MIRROR] Gasping in shock, but for non-humans! #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* makes gaspshock no longer limited to humans * Revert "makes gaspshock no longer limited to humans" This reverts commit 06e4d2d7dcce182d832d9b3e3ea9f10a2d7d5211. * makes *gaspshock no longer limited to humans * SKYRAT EDIT CHANGE comment Co-authored-by: Bloop <[email protected]> * Update code/modules/mob/living/emote.dm * Update code/modules/mob/living/emote.dm * Update code/modules/mob/living/emote.dm --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 7, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 17, 2024
… vending machines. (#1007) * Fixes `product_categories` not working for non-constructable vending machines. (#81467) ## About The Pull Request This is something I've discovered while working on the previous PR. ## Why It's Good For The Game Prevents future issues with non-constructable vending machines that use categories, since we don't have any such thing rn. ## Changelog N/A * Fixes `product_categories` not working for non-constructable vending machines. --------- Co-authored-by: Ghom <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 19, 2024
… vending machines. (#1007) (#2020) * Fixes `product_categories` not working for non-constructable vending machines. (#81467) ## About The Pull Request This is something I've discovered while working on the previous PR. ## Why It's Good For The Game Prevents future issues with non-constructable vending machines that use categories, since we don't have any such thing rn. ## Changelog N/A * Fixes `product_categories` not working for non-constructable vending machines. --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25470
About The Pull Request
This PR should make *gaspshock available for non-human species.
How This Contributes To The Skyrat Roleplay Experience
*gaspshock used to be limited to humans only, which.. did not make much sense.
Now everyone can gasp in shock!
Proof of Testing
Screenshots/Videos
https://cdn.discordapp.com/attachments/640760727489085450/1182094163748061284/Is6ZPUT.mp4?ex=658371fa&is=6570fcfa&hm=d3b87cbbafb5b260668c10602620df11d166029acc94674dc59f87ea69ece903&
Changelog
🆑 KannaLisvern
fix: *gaspshock being only limited to humans
/:cl: