Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes the typing indicator #1011

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[MIRROR] Fixes the typing indicator #1011

merged 1 commit into from
Dec 7, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25475
Original PR: tgstation/tgstation#80153

About The Pull Request

It was very specifically broken by this commit, because it wrongfully changed the logic. Now the typing indicator is back, it's no longer just the thinking indicator.

Why It's Good For The Game

Typing indicator is meant to be there, now it's back! No more awkward flickering!

Changelog

🆑 GoldenAlpharex
fix: The typing indicator has overcome its shyness and is now back to its usual form.
/:cl:

* Fixes the typing indicator (#80153)

## About The Pull Request
It was very specifically broken by [this
commit](tgstation/tgstation@94d00aa),
because it wrongfully changed the logic. Now the typing indicator is
back, it's no longer just the thinking indicator.

## Why It's Good For The Game
Typing indicator is meant to be there, now it's back! No more awkward
flickering!

## Changelog

:cl: GoldenAlpharex
fix: The typing indicator has overcome its shyness and is now back to
its usual form.
/:cl:

* Fixes the typing indicator

---------

Co-authored-by: GoldenAlpharex <[email protected]>
@Iajret Iajret merged commit 615f261 into master Dec 7, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25475 branch December 7, 2023 09:30
AnywayFarus added a commit that referenced this pull request Dec 7, 2023
Iajret pushed a commit that referenced this pull request Feb 17, 2024
* Fixes some issues with paper planes

* Modularize this (better better paper planes)

---------

Co-authored-by: John Willard <[email protected]>
Co-authored-by: Mal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants