[MIRROR] Fix build mode preview spawning atoms needlessly #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…] (#25476) * Fix build mode preview spawning atoms needlessly (#80130) Before the large icon fix, it would use a mutable_appearance, get_small_overlay wants atoms but it only does appearance things with them so images and mutable appearances should work. There is no need to spawn the atom itself. We will at some point need a way to specify interfaces as argument types, many such cases of atom or image or mutable_appearance in icon related procs. closes #80125 * Fix build mode preview spawning atoms needlessly --------- Co-authored-by: Kyle Spier-Swenson <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Adds a proper skeletal rack subtype (#81484) ## About The Pull Request This is mapped in a few places and I thought it would be better to have a subtype of rack to use rather than varediting the icon and state. ## Why It's Good For The Game The less varedited icons the better imo, it's way easier to ensure icons aren't fucked up this way and easier to fix too. ## Changelog No player-facing changes. * Adds a proper skeletal rack subtype --------- Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25476
Original PR: tgstation/tgstation#80130
Before the large icon fix, it would use a mutable_appearance, get_small_overlay wants atoms but it only does appearance things with them so images and mutable appearances should work. There is no need to spawn the atom itself.
We will at some point need a way to specify interfaces as argument types, many such cases of atom or image or mutable_appearance in icon related procs.
closes #80125