Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix cult halo and eyes affecting deconverted cultists #1013

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25477
Original PR: tgstation/tgstation#80148

About The Pull Request

Fixes #69423

Cult halo and eyes were appearing on deconverted cultists due to a delay when the element gets attatched. This lead to a small window of oppurtunity where someone could get converted, then deconverted, and still have the cult icons appear on them later.

Why It's Good For The Game

The Antichrist is dead.

Changelog

🆑 timothymtorres
fix: Fix cult halo and eyes affecting deconverted cultists
/:cl:

…GNORE] (#25477)

* Fix cult halo and eyes affecting deconverted cultists (#80148)

## About The Pull Request

Fixes #69423

Cult halo and eyes were appearing on deconverted cultists due to a delay
when the element gets attatched. This lead to a small window of
oppurtunity where someone could get converted, then deconverted, and
still have the cult icons appear on them later.

## Why It's Good For The Game

The Antichrist is dead.

## Changelog

:cl:
fix: Fix cult halo and eyes affecting deconverted cultists
/:cl:

* Fix cult halo and eyes affecting deconverted cultists

---------

Co-authored-by: Tim <[email protected]>
@Iajret Iajret merged commit 95e93b1 into master Dec 7, 2023
23 checks passed
AnywayFarus added a commit that referenced this pull request Dec 7, 2023
@Iajret Iajret deleted the upstream-mirror-25477 branch December 12, 2023 23:21
Iajret pushed a commit that referenced this pull request Feb 17, 2024
* Cardboard cutouts are now tactical. (#81245)

## About The Pull Request
Basically, this means players holding cardboard cutouts will now assume
their appearance, just like for potted plants. Good for pranking.

I've had to tweak the tactical component and the waddling element a bit
to get them to work as intended while dealing with the multiple sources
of the waddling element.

## Why It's Good For The Game
![](https://media1.tenor.com/m/X1GimXmuByYAAAAd/tom-cruise-doorbell.gif)

## Changelog

:cl:
add: Players holding cardboard cutouts will now assume their appearance,
just like for potted plants.
/:cl:

* Cardboard cutouts are now tactical.

---------

Co-authored-by: Ghom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants