[MIRROR] Removes ban-bait gear lockers from modular ERT Ferry #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes banbait-filled lockers
AnywayFarus
added a commit
that referenced
this pull request
Dec 7, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 18, 2024
* Fix lifeline not respecting suit sensors (#81517) ## About The Pull Request - Lifeline app now respect suits sensors again. - The proc always `return .`'d if the target mob was not on suit sensors, so if `.` was `RADAR_TRACKABLE`, well, it would rack sensorless mobs. - Cleaned up a bit of trackable. - Use the `is_valid_z_level` helper. - Respect all possible returns for a signal. ## Changelog :cl: Melbert fix: Lifeline can no longer track mobs with suit sensors off /:cl: * Fix lifeline not respecting suit sensors --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25421
About The Pull Request
Title
How This Contributes To The Skyrat Roleplay Experience
TG's ERT shuttles explicitly have zero gear on them, for one big reason: ERTs do not stay to monitor the shuttle. Why would they, their job is to respond to the issues.
Having all this unused gear just sitting on an unattended shuttle that's not mentioned as being "off limits" in the rules, but is enforced as such, is just ban baiting. There's zero reason to have all this unattended gear, especially when it's either ERT-specific gear or unmaintained/admin weapons (cough cough taser).
ERTs can, should, and DO gear up before even getting aboard the Ferry. It's a Ferry. For ferrying passengers. Not for gear storage.
Proof of Testing
The ERT Modsuit is gone, as well as the Adminspawn taser-combo weapon, and the spare security armor. In its place, spare oxygen supplies, another chair, and more consoles so the whole team can see the cameras.
Changelog
🆑 OrionTheFox
balance: removed all the unsecured gear on the ERT Ferry. Consider this a reminder that all ERTs are expected to be fully prepared before departing for the station.
/:cl: