[MIRROR] Deletes unused hydroponics code #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deletes unused hydroponics code (#80156) ## About The Pull Request `/obj/item/seeds/sample` was completely unused, ever since it's inception in #16082 (tgstation/tgstation@d513f52) as far as I can tell (Me when "adds plant samples for future use" never makes use of them in the future) All this does is complicate hydro code so it dies. Anything it is doing should be handled by genes probably While I was here I made sure nothing in `can_add` will break and touched up the code a tiny tiny bit. I kept it as `SHOULD_CALL_PARENT` even though it doesn't make use of it at the moment because every trait currently calls parent / respects return value, so sure, why not ## Changelog Not necessary * Deletes unused hydroponics code --------- Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 18, 2024
…ton (#1015) * Changes the crystallizer wrench screentip to the correct button (#81516) ## About The Pull Request it says left click, that does nothing, you need to right click it to rotate ## Why It's Good For The Game correct ingame information ## Changelog :cl: fix: The crystallizer screentip for rotating it has been updated with the correct button /:cl: * Changes the crystallizer wrench screentip to the correct button --------- Co-authored-by: 1393F <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25480
Original PR: tgstation/tgstation#80156
About The Pull Request
/obj/item/seeds/samplewas completely unused, ever since it's inception in #16082 (tgstation/tgstation@d513f52) as far as I can tell(Me when "adds plant samples for future use" never makes use of them in the future)
All this does is complicate hydro code so it dies.
Anything it is doing should be handled by genes probably
While I was here I made sure nothing in
can_addwill break and touched up the code a tiny tiny bit. I kept it asSHOULD_CALL_PARENTeven though it doesn't make use of it at the moment because every trait currently calls parent / respects return value, so sure, why notChangelog
Not necessary