[MIRROR] [Modular] Hash is no longer recursive #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnywayFarus
added a commit
that referenced
this pull request
Dec 9, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 19, 2024
* deathmatch (#81444) ## About The Pull Request  adds a deathmatch minigame, a port and slightly redone version of the aetherstation deathmatch (by TheChosenEvilOne) the goal is to kill everyone else with loadouts ## Why It's Good For The Game CTF sucks and this is probably better to filter out the bloodthirsty terry players anyway ## Changelog :cl: add: deathmatch minigame /:cl: --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Ghom <[email protected]> * deathmatch --------- Co-authored-by: jimmyl <[email protected]> Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25486
About The Pull Request
This fixes a bug with hash which caused it to infinity react when it was in lava, as when hash bricks are in lava it reacts and becomes dabs. But fun fact, its a chemical reaction because of the THC in the hash bricks, and guess what also has THC in it? Dabs, which resulted in the newly created DABS which has even more THC in it than hash to react and create MORE dabs, which then ALSO reacts. Which lead to a infinite recursion of dabs creating itself and duplicating over and over infinity over a very very short time frame
Credit to @Iamgoofball for helping identify this bug
How This Contributes To The Skyrat Roleplay Experience
No more server crashes
Proof of Testing
Screenshots/Videos
Changelog
🆑 SomeRandomOwl and Iamgoofball
fix: Hash Bricks and Dabs are no longer recursive
/:cl: