[MIRROR] Removes an exploit that can farm Russian revolver moodlets, adds Russian revolvers to the contraband section of games vendors #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adds Russian revolvers to the contraband section of games vendors [MDB IGNORE] (#25493) * Removes an exploit that can farm Russian revolver moodlets, adds Russian revolvers to the contraband section of games vendors (#80159) ## About The Pull Request Fixes tgstation/tgstation#80158 by making curses block you from playing Russian roulette regardless of whether or not there's a live bullet in your Russian revolver's chamber. A Russian revolver has been added to the contraband section of each Good Clean Fun vendor. ## Why It's Good For The Game The bug is incredibly funny, but ~~I want GBP~~ probably should be fixed. There's no actual way to get (more) Russian revolvers outside of the mapstart ones, and that can be a bit stifling to gimmicks that involve them. And Russian roulette IS a game. Like the roundstart ones, you could unload these vendor revolvers for .357 bullets, but you can already just print .357 bullets from a hacked autolathe directly, so I don't think that's an issue. ## Changelog :cl: ATHATH fix: Spacemen can no longer use curses to cheat at Russian roulette by selectively blocking attempts to shoot themselves. add: A Russian revolver has been added to the contraband section of each Good Clean Fun vendor. /:cl: --------- Co-authored-by: Jacquerel <hnevard@ gmail.com> * Removes an exploit that can farm Russian revolver moodlets, adds Russian revolvers to the contraband section of games vendors --------- Co-authored-by: ATH1909 <[email protected]> Co-authored-by: Jacquerel <hnevard@ gmail.com>
AnywayFarus
added a commit
that referenced
this pull request
Dec 9, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 27, 2024
* initial d * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * there are consequences to your crimes against dracula * a real human being * ayo * wowza * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Update modular_nova/modules/synths/code/bodyparts/internal_computer/internal_computer.dm Co-authored-by: Bloop <[email protected]> * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * wew * yay * Moves signal proc to the pda itself * Starting with id already equipped will auto-link it to the synth brain computer * Make sure removing from pda/wallets unlink properly * Fixes pdas and wallets edge cases (hopefully) * Update internal_computer.dm * This got so needlessly complicated --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25493
Original PR: tgstation/tgstation#80159
About The Pull Request
Fixes tgstation/tgstation#80158 by making curses block you from playing Russian roulette regardless of whether or not there's a live bullet in your Russian revolver's chamber.
A Russian revolver has been added to the contraband section of each Good Clean Fun vendor.
Why It's Good For The Game
The bug is incredibly funny, but
I want GBPprobably should be fixed.There's no actual way to get (more) Russian revolvers outside of the mapstart ones, and that can be a bit stifling to gimmicks that involve them. And Russian roulette IS a game.
Like the roundstart ones, you could unload these vendor revolvers for .357 bullets, but you can already just print .357 bullets from a hacked autolathe directly, so I don't think that's an issue.
Changelog
🆑 ATHATH
fix: Spacemen can no longer use curses to cheat at Russian roulette by selectively blocking attempts to shoot themselves.
add: A Russian revolver has been added to the contraband section of each Good Clean Fun vendor.
/:cl: