[MIRROR] Fixes coffin cookie being invisible #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes coffin cookie being invisible (#80179) ## About The Pull Request - Fixes #80161 It's a seasonal bug i.e. occurs only during the holiday seasons. Yeah so its caused by this code https://github.com/tgstation/tgstation/blob/2a359b817874c4bb52be814551780af304cc9e07/code/game/objects/items/food/pastries.dm#L191-L194 So like it changes the icon state based on the season. Unfortunately none of the icon states it picks are located in the icon file `'icons/obj/holiday/halloween_items.dmi` i.e. it causes an invalid icon state causing it to go invisible(not spooky just a bug). We now make sure this cookie type does not change based on the season. It will stay unique throughout the year ## Changelog :cl: fix: coffin cookies are no longer invisible during the holiday seasons /:cl: --------- Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com> * Fixes coffin cookie being invisible --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Dec 9, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 18, 2024
* Reverts map vote to single method (#81539) ## About The Pull Request Reverts map vote to single selection rather than multi selection ## Why It's Good For The Game Now that map vote is weighted, multi selection serves no purpose anymore other than allowing people to gain "additional weight" in the vote, which is unfair. It's weighted, everyone should have 1 vote.  ## Changelog :cl: Melbert del: You can only vote for 1 map at a time again /:cl: * Reverts map vote to single method * Update override --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25510
Original PR: tgstation/tgstation#80179
About The Pull Request
It's a seasonal bug i.e. occurs only during the holiday seasons. Yeah so its caused by this code
https://github.com/tgstation/tgstation/blob/2a359b817874c4bb52be814551780af304cc9e07/code/game/objects/items/food/pastries.dm#L191-L194
So like it changes the icon state based on the season. Unfortunately none of the icon states it picks are located in the icon file
'icons/obj/holiday/halloween_items.dmii.e. it causes an invalid icon state causing it to go invisible(not spooky just a bug).We now make sure this cookie type does not change based on the season. It will stay unique throughout the year
Changelog
🆑 SyncIt21
fix: coffin cookies are no longer invisible during the holiday seasons
/:cl: