Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Ports React [READY] #1054

Merged
merged 1 commit into from
Dec 10, 2023
Merged

[MIRROR] Ports React [READY] #1054

merged 1 commit into from
Dec 10, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25505
Original PR: tgstation/tgstation#80044

About The Pull Request

Moves us from Inferno 7.4.11 to React 18.2. This is a big project! You might find errors here. Sometimes I get carried away fixing external issues, I'll try to atomize them into separate PRs.

  • Implements React
  • CSS kebab to camel case
  • Some typescript refactors
  • Atomize what I can
  • Fix dropdowns (opens in the wrong location)
  • Fix wonky button placement in a few UIs
  • Cleanup

Why It's Good For The Game

  • It'd be nice to just have real hooks. Our implementation is probably the best possible for Inferno, don't get me wrong.
  • React is just easier to maintain and easier to read. It's the web dev standard.

Closes #78221

Changelog

🆑 jlsnow301
refactor: TGUI V5: The UI has had its entire engine replaced with React v18.2. This might cause obvious or laughably broken UIs in places you wouldn't expect. Please report any issues you find to the repo!
/:cl:

* Ports React [READY]

* Fix merge conflicts

* I hate you javascript

* Fixes some issues

* Bring back the padding

* Update JobsPage.tsx

* Squeezing every last drop of space

* Update AntagInfoAssaultops.tsx

* More react compat

---------

Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: Giz <[email protected]>
@Iajret Iajret merged commit 07cf885 into master Dec 10, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25505 branch December 10, 2023 22:06
AnywayFarus added a commit that referenced this pull request Dec 10, 2023
Iajret added a commit to Iajret/FluffySTG that referenced this pull request Dec 11, 2023
Iajret pushed a commit that referenced this pull request Feb 20, 2024
* Air alarms display location/trigger information (#81436)

## About The Pull Request

Adds additional information to triggered fire alarms, viewable on the
air alarm. Displays the method of alarm trigger and the source of the
alarm.


![image](https://github.com/tgstation/tgstation/assets/83487515/2b8bb334-e641-451b-9d6d-97e650e74032)

## Why It's Good For The Game

Useful for engineers to track down the source of why the fire
alarm/firedoors are triggering. Fire alarms that are manually triggered
will never reset without intervention, so this also identifies these
cases instead of chasing down an issue that may not exist.

## Changelog

:cl: LT3
qol: Air alarms now display the source of triggered fire
alarms/firedoors
/:cl:

* Air alarms display location/trigger information

---------

Co-authored-by: lessthanthree <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants