[MIRROR] Healing Virus Selfcure Hotfix #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[NO GBP] Healing Virus Selfcure Hotfix Co-authored-by: Higgin <[email protected]> Co-authored-by: Giz <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-25526
AnywayFarus
added a commit
that referenced
this pull request
Dec 11, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Reaction & holder tweaks (#81545) ## About The Pull Request - Fixes #81537. For competing reactions where reaction B consumes the results formed from reaction A `total_step_added` yields values higher than the actual volume of products formed causing the reaction to end early leading to less volume of product formed as explained in the comment - Removes `update_total()` from instant reactions as it already does that for us making it a little faster - merges `remove_all_direct()` with `remove_all()` to reduce code as their functionalities are very similar ## Changelog :cl: fix: multiple reactions occuring in the same holder like mixing drinks will yield correct reagent result volumes code: Removes `update_total()` from instant reactions improving performance slightly code: merges `remove_all_direct()` with `remove_all()` to reduce code size /:cl: * Reaction & holder tweaks --------- Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25526
Original PR: tgstation/tgstation#80172
About The Pull Request
Fixes a logic issue in how healing viruses were supposed to self-cure that basically never came out in practice but wasn't intended.
Why It's Good For The Game
fix good, makes it so starving nutrition OR negative satiety can mess up a healing virus, makes TRAIT_NOHUNGER properly protect against losing a healing virus without spaceacillin
Changelog
🆑 Higgin
fix: Healing viruses now no longer self-cure for reasons they're not supposed to and do for those that they are.
/:cl: