[MIRROR] Logging fixes and catches #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Logging fixes and catches (#79621) THIS IS A REDO BECAUSE GITHUB SUCKS ASS ## About The Pull Request Hardens logging against sudden and unexpected cases where we try to log to a category that is not initialized or the file goes missing. ## Why It's Good For The Game Logging needs to be robust and bullet proof * Logging fixes and catches --------- Co-authored-by: Zephyr <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 20, 2024
…out buttons on UI (#1057) * Paintings update: Curators get a cut on patronage + zoom in/out buttons on UI (#81500) ## About The Pull Request (Roundstart) Curators now get a 22.5% cut on credits spent on painting patronages (divided by the number of curators). The service department also gets another, 12.5% cut. This PR also adds zoom in/out buttons to the painting canvas UI. So you don't have to stare at a blob of such enormous squares while the UI is open, which is only good when drawing. Screenshot copypaste in paint: ## Why It's Good For The Game The painting feature is mostly an end in itself, which is totally fine. I've put quite a few quality-of-life changes into it through the years, and I still want to kick in some stuff. However, I think the curator should actually benefit from them in a more "mechanical" way. Furthermore, I personally prefer them over the random written crap that players make. Also, as I said above, the canvas UI can feel a tad too big at times. * Paintings update: Curators get a cut on patronage + zoom in/out buttons on UI --------- Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25537
Original PR: tgstation/tgstation#79621
THIS IS A REDO BECAUSE GITHUB SUCKS ASS
About The Pull Request
Hardens logging against sudden and unexpected cases where we try to log to a category that is not initialized or the file goes missing.
Why It's Good For The Game
Logging needs to be robust and bullet proof