[TG Mirror] Fixes CI failure from AttackingTarget not passing the attacked_target in its args [MDB IGNORE] #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_target in its args [MDB IGNORE] (#24402) * Fixes CI failure from AttackingTarget not passing the attacked_target in its args (#79037) ## About The Pull Request CI started spamming with runtimes.  `AttackingTarget()` wasn't passing the `target` as an arg. Fixes that. Also added the arg in a bunch of its overrides because they were not there. I know we're phasing out simple mobs but in the meantime broken things bad. ## Why It's Good For The Game Fixes bug ## Changelog :cl: fix: fixed runtime caused by simple mobs AttackingTarget() missing an arg /:cl: * Fixes CI failure from AttackingTarget not passing the attacked_target in its args --------- Co-authored-by: Bloop <[email protected]>
FluffySSbot
added a commit
that referenced
this pull request
Oct 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Dec 31, 2023
* Fixes confetti shotgun shells (#174) * initial * fix confetti shell * donkpocket sprites and more * this is for a different PR * forgot these * ..() * reviews * // instead of /// for overrides --------- Co-Authored-By: Bloop <[email protected]> * New Quirk: Appendicitis Survivor (#77) ## About The Pull Request Title. ## How This Contributes To The Nova Sector Roleplay Experience Spontaneous appendicitis is.. an event! This adds the Appendicitis Survivor quirk from my server, [TaleStation](https://github.com/TaleStation/TaleStation). Its a positive (-2) quirk, while low impact, some people may appreciate. Its also another low cost quirk, so people could pick it up if so desired. ## Proof of Testing <details> <summary>Screenshots/Videos</summary>  </details> ## Changelog :cl: Jolly add: New quirk for those who hate their appendix: Appendicitis Survivor! A positive (-2) quirk. /:cl: * Improves the names, descriptions, and extended descriptions of nearly all my firearms (#90) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Three steps 1. Guns no longer list their company in their name, this made some gun names too long to refer to or just look weird. 2. Every gun now tells you what it fires in its examine if it didn't before. 3. Every gun's examine text now hints that you can double examine for more info on the weapon. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Makes a lot of information about these weapons more convenient or more apparent than they were before, and removes some unneeded information (like we didnt really have to have the guys that made the gun displayed straight in the name, you can see the company that makes them in the examine text already). <!-- Please add a short description of why you think these changes would benefit the game and the roleplay atmosphere of the server. If you can't justify it in words, it might not be worth adding. --> <!-- Include any screenshots/videos/debugging steps of the code functioning successfully, between the </summary> and </details> code blocks. --> <!-- To our mappers and spriters: Posting screenshots of content INSIDE EDITORS (aseprite, PDN, SDMM, ect) is NOT valid proof of testing. Please make sure that you COMPILE the game and provide PROOF you tested your edits. --> <details> <summary>Screenshots/Videos</summary>   </details> <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: qol: The names and descriptions of every paxilmaniac weapon have been improved to be shorter (names) and mention at least what bullet the weapon fires (description) qol: Every weapon with an extended description has a hint in its normal examine telling you that you can look further to get more info on the weapon code: Two instances of now-deleted weapons paths (which i found out about through someone getting one in a christmas tree) existing due to manufacturer examines of all things have been cleaned up, players wont notice this one i think /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Re-adding Cat Scream (Normalized) (#123) * Re-adding Cat Scream (Normalized) * Update modular_nova/modules/emotes/code/scream_datums.dm Renamed the file from cat.ogg to cat_scream.ogg Co-authored-by: GoldenAlpharex <[email protected]> * Renamed cat.ogg to cat_scream.ogg * removed cat.ogg and replaced with cat_scream.ogg * Removes old scream sounds, renames it properly --------- Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]> * [MODULAR] Fixes clockcult slab ui, some runtimes (#122) Fixes slab ui, some runtimes * [MODULAR] Fixes colonial cloaks not being able to hold any suit storage items (#129) * Fixes imperial police cloak not being able to hold any suit storage items * Moves this to the NRI police cloak * Moves this to the NRI police cloak * Update clothing.dm * Update modular_nova/modules/novaya_ert/code/police_outfit.dm --------- Co-authored-by: GoldenAlpharex <[email protected]> * Resprited Vox Clothing (Nova Station Edition) (#97) * Resprited Vox Clothing * Update screenshot_humanoids__datum_species_vox_primalis.png --------- Co-authored-by: Bloop <[email protected]> * Chitter emote is the TG chitter sound unless you're a moth (#111) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Changes the *chitter emote to play the standard TG chitter sfx, unless you're a moth, then it plays the moth chitter. TG chitter is cute. <!-- Include any screenshots/videos/debugging steps of the code functioning successfully, between the </summary> and </details> code blocks. --> <!-- To our mappers and spriters: Posting screenshots of content INSIDE EDITORS (aseprite, PDN, SDMM, ect) is NOT valid proof of testing. Please make sure that you COMPILE the game and provide PROOF you tested your edits. --> <details> <summary>Screenshots/Videos</summary> https://github.com/NovaSector/NovaSector/assets/77534246/eae4fc45-d104-4588-8537-394da9304151 </details> <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: add: Chitter emote has a different sound effect, unless you're a moth /:cl: * Adds fancy masquerade masks (#180) * Adds masquerade masks, making them available in the AutoDrobe Thanks to Crumpaloo for the sprites! * Early mirror of tgstation/tgstation#80663 They're not properly usable otherwise * Updates the sprites so they've got transparent eyes * Adds the masks to the loadout * Fixes variation flags and muzzled GAGS config, makes it act as internals * Adjust some of the sprites a bit more, making snouted ones have smaller eyeholes, and vox ones looking more like masquerade masks * Updates the sprites for the Vox Primalis! --------- * Update greyscale_configs.dm * Fixes Niftsoft Settings Panel (#208) Fixes Niftsoft Settings * 0 --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: Kyogon <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: HalcyonicWolf <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Re-adding Cat Scream (Normalized) * Update modular_nova/modules/emotes/code/scream_datums.dm Renamed the file from cat.ogg to cat_scream.ogg Co-authored-by: GoldenAlpharex <[email protected]> * Renamed cat.ogg to cat_scream.ogg * removed cat.ogg and replaced with cat_scream.ogg * Removes old scream sounds, renames it properly --------- Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24402
Original PR: tgstation/tgstation#79037
About The Pull Request
CI started spamming with runtimes.
AttackingTarget()wasn't passing thetargetas an arg. Fixes that. Also added the arg in a bunch of its overrides because they were not there. I know we're phasing out simple mobs but in the meantime broken things bad.Why It's Good For The Game
Fixes bug
Changelog
🆑 vinylspiders
fix: fixed runtime caused by simple mobs AttackingTarget() missing an arg
/:cl: