[TG Mirror] Fixes a bug with the scope getting stuck on mobs that get dusted or ghost [MDB IGNORE] #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sted or ghost [MDB IGNORE] (#24404) * Fixes a bug with the scope getting stuck on mobs that get dusted or ghost (#78941) ## About The Pull Request If you ghost while mid-scope (or similarly, if you get dusted/your mob gets deleted) the mob's cursor would get all messed up due to some oversights. This just clears up some of these logic errors and ensures everything gets cleaned up properly. Fixes Skyrat-SS13/Skyrat-tg#24189 Fixes tgstation/tgstation#78756 ## Why It's Good For The Game Fixes a bug. I don't think scopes are even in use here but they are downstream. <details> <summary>Deleted and being dusted resets perspective and cursor properly</summary>   </details> <details> <summary>So does ghosting</summary>  </details> ## Changelog :cl: fix: being killed or ghosting while being scoped will no longer cause the cursor offset to persist in a bugged state /:cl: --------- Co-authored-by: san7890 <the@ san7890.com> * Fixes a bug with the scope getting stuck on mobs that get dusted or ghost --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: san7890 <the@ san7890.com>
FluffySSbot
added a commit
that referenced
this pull request
Oct 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Dec 28, 2023
) Adds turf checks for mercury & lithium random step logic. (#80586) ## About The Pull Request - Fixes #74092 We not only want to make sure it's a turf but also a ground turf (i.e. something you can stand on and not turfs like lava, water, space etc) so you know you can use your legs to move on that ground. ## Changelog :cl: fix: mercury & lithium will no longer make you randomly move outside of cryotubes or in ground less turfs (space, water, lava etc) /:cl: Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24404
Original PR: tgstation/tgstation#78941
About The Pull Request
If you ghost while mid-scope (or similarly, if you get dusted/your mob gets deleted) the mob's cursor would get all messed up due to some oversights. This just clears up some of these logic errors and ensures everything gets cleaned up properly.
Fixes Skyrat-SS13/Skyrat-tg#24189
Fixes tgstation/tgstation#78756
Why It's Good For The Game
Fixes a bug. I don't think scopes are even in use here but they are downstream.
Deleted and being dusted resets perspective and cursor properly
So does ghosting
Changelog
🆑 vinylspiders
fix: being killed or ghosting while being scoped will no longer cause the cursor offset to persist in a bugged state
/:cl: