[TG Mirror] Fixes source of tgui errors in accounts console [MDB IGNORE] #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (#24412) * Fixes source of tgui errors in accounts console (#79048) ## About The Pull Request It's possible to have bank accounts created with `null` jobs. This results in a runtime bluescreen that breaks the account management console for the whole round. <details><summary>Not ideal</summary>   </details> The runtime comes from trying to access `title` from the null job datum in `ui_data()` which results in the ui data not being sent. https://github.com/tgstation/tgstation/blob/c10bf15c4a9b71eec325ea2f201a68defb80943b/code/game/machinery/computer/accounting.dm#L22-L29 --- This PR just guards against that. Similar patterns can be seen everywhere else where this data is accessed. <details><summary> For example</summary>   </details> ## Why It's Good For The Game More robust code, less console becoming unusable. ## Changelog :cl: fix: fixes a tgui bluescreen bug with the bank account console that can occur when there is bad bank account data /:cl: * Fixes source of tgui errors in accounts console --------- Co-authored-by: Bloop <[email protected]>
FluffySSbot
added a commit
that referenced
this pull request
Oct 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Dec 28, 2023
#127) Makes the turbine core part remove references on deactivation (#80593) ## About The Pull Request The delete the world test was showing that the turbine's non-core parts, the compressor and outlet were causing runtimes, so I made the deactivation of the core remove the references from the secondary turbine parts ## Why It's Good For The Game Less harddels means less lag, hopefully No changelog since nothing player facing Co-authored-by: Arturlang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24412
Original PR: tgstation/tgstation#79048
About The Pull Request
It's possible to have bank accounts created with
nulljobs. This results in a runtime bluescreen that breaks the account management console for the whole round.Not ideal
The runtime comes from trying to access
titlefrom the null job datum inui_data()which results in the ui data not being sent.https://github.com/tgstation/tgstation/blob/c10bf15c4a9b71eec325ea2f201a68defb80943b/code/game/machinery/computer/accounting.dm#L22-L29
This PR just guards against that. Similar patterns can be seen everywhere else where this data is accessed.
For example
Why It's Good For The Game
More robust code, less console becoming unusable.
Changelog
🆑 vinylspiders
fix: fixes a tgui bluescreen bug with the bank account console that can occur when there is bad bank account data
/:cl: