[TG Mirror] Heretic summon name fixes #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Heretic summon name fixes (#79055)
## About The Pull Request
Fixes #79049.
The ghost poll for heretic summons used the `real_name` field to display
the mob's name. However, for some reason, a couple of the heretic
summons have jokey nicknames as their real names ("Ashy" for ash
walkers, "Rusty" for rust walkers). I've opted to take the simple option
of making the ghost text just use the `name` field instead - it's used
for the admin logs around summoning, so it should be fine for the poll
too.
Also, I've capitalized "Fire Shark" and set its real name to also be
"Fire Shark". For consistency.
Finally, I've made heretic summon names not proper nouns, so examining
them will display "That's a Rust Walker" rather than "That's Rust
Walker". The Lord of the Night did not receive this treatment due to
being a unique thing.
## Why It's Good For The Game
It's good when ghosts know what they're actually signing up to be.
Most heretic summons aren't unique entities, so it makes sense for them
to not be proper nouns.
## Changelog
:cl:
fix: Heretic summons should now display the correct name when polling
ghosts to play as them.
/:cl:
* Heretic summon name fixes
---------
Co-authored-by: lizardqueenlexi <[email protected]>
Steals-The-PRs
added a commit
that referenced
this pull request
Oct 19, 2023
Iajret
pushed a commit
that referenced
this pull request
Dec 28, 2023
…otta other missing images (#140) * Cache sprite data alongside spritesheets, fixing emotes and a whole lotta other missing images (#80601) * Cache sprite data alongside spritesheets, fixing emotes and a whole lotta other missing images * Update cleanbot_ai.dm --------- Co-authored-by: Mothblocks <[email protected]> Co-authored-by: NovaBot <[email protected]> Co-authored-by: Giz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24432
Original PR: tgstation/tgstation#79055
About The Pull Request
Fixes #79049.
The ghost poll for heretic summons used the
real_namefield to display the mob's name. However, for some reason, a couple of the heretic summons have jokey nicknames as their real names ("Ashy" for ash walkers, "Rusty" for rust walkers). I've opted to take the simple option of making the ghost text just use thenamefield instead - it's used for the admin logs around summoning, so it should be fine for the poll too.Also, I've capitalized "Fire Shark" and set its real name to also be "Fire Shark". For consistency.
Finally, I've made heretic summon names not proper nouns, so examining them will display "That's a Rust Walker" rather than "That's Rust Walker". The Lord of the Night did not receive this treatment due to being a unique thing.
Why It's Good For The Game
It's good when ghosts know what they're actually signing up to be.
Most heretic summons aren't unique entities, so it makes sense for them to not be proper nouns.
Changelog
🆑 lizardqueenlexi
fix: Heretic summons should now display the correct name when polling ghosts to play as them.
/:cl: