[TG Mirror] Fixes hole in ventcrawl logic #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes hole in ventcrawl logic (#79027) ## About The Pull Request May or may not close tgstation/tgstation#79018 Basically we slept during the `do_after()` and the vent may have been welded while we were sleeping, meaning we could "phase through a welded vent". Just a silly hole in ventcrawling logic that we should be accounting for. ## Why It's Good For The Game I think there's a few issues with ventcrawling (i.e. it being traitbased and not something like an element) but we can tackle that later. Let's just fix any potential holes and issues that might come with it. ## Changelog :cl: fix: People should be crawling into welded vents a lot less now. /:cl: No guarantee on the linked issue disappearing since I couldn't replicate it on my end, just noticed a logic failure. * Fixes hole in ventcrawl logic --------- Co-authored-by: san7890 <[email protected]>
Steals-The-PRs
added a commit
that referenced
this pull request
Oct 19, 2023
Iajret
pushed a commit
that referenced
this pull request
Dec 28, 2023
* Fixes input value not clearing on NTOS app [no gbp] (#80614) ## About The Pull Request Problem goes a little deeper than simply adding "selfClear" prop - ntos messenger is looking for more of a controlled component. Whenever messages are sent, it attempts to update the value in the input box ## Why It's Good For The Game Fixes #80611 ## Changelog :cl: fix: NTOS Messenger should clear on enter now /:cl: * Fixes input value not clearing on NTOS app [no gbp] --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24429
Original PR: tgstation/tgstation#79027
About The Pull Request
May or may not close tgstation/tgstation#79018
Basically we slept during the
do_after()and the vent may have been welded while we were sleeping, meaning we could "phase through a welded vent". Just a silly hole in ventcrawling logic that we should be accounting for.Why It's Good For The Game
I think there's a few issues with ventcrawling (i.e. it being traitbased and not something like an element) but we can tackle that later. Let's just fix any potential holes and issues that might come with it.
Changelog
🆑 san7890
fix: People should be crawling into welded vents a lot less now.
/:cl:
No guarantee on the linked issue disappearing since I couldn't replicate it on my end, just noticed a logic failure.