Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] fixes touching minebots not changing combat mode (#80789) #1473

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#340
tgstation/tgstation#80789

About The Pull Request

uhh touch with empty hand and off combat mode and they change combat mode now

Why It's Good For The Game

fixes #80584

Changelog

🆑 mc-oofert
fix: you can use your hand to make minebots go into combat mode again /:cl:

…789) (#340)

fixes touching minebots not changing combat mode (#80789)

## About The Pull Request

uhh touch with empty hand and off combat mode and they change combat
mode now

## Why It's Good For The Game

fixes #80584

## Changelog
:cl:
fix: you can use your hand to make minebots go into combat mode again
/:cl:

Co-authored-by: jimmyl <[email protected]>
@Iajret Iajret merged commit d9bd5a2 into master Jan 6, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-340 branch January 6, 2024 19:37
AnywayFarus added a commit that referenced this pull request Jan 6, 2024
Iajret pushed a commit that referenced this pull request Mar 16, 2024
* Fixes sec computers having infinite distance (#82016)

## About The Pull Request

Camera consoles no longer have infinite range, which was caused by the
``can_perform_action`` check causing an early return before
``try_update_ui`` could run and update your visibility on the console.

This has been a bug for a long time and I've constantly procrastinated
on fixing it but it was brought up when discussing Human AI bugs so I
went in to look around and found out what caused it, so I can finally
say I did it.

## Why It's Good For The Game

Security cameras no longer have infinite range.

## Changelog

:cl:
fix: Security camera consoles no longer have infinite range.
/:cl:

* Fixes sec computers having infinite distance

---------

Co-authored-by: John Willard <[email protected]>
ReezeBL pushed a commit that referenced this pull request Mar 17, 2024
* Fixes sec computers having infinite distance (#82016)

## About The Pull Request

Camera consoles no longer have infinite range, which was caused by the
``can_perform_action`` check causing an early return before
``try_update_ui`` could run and update your visibility on the console.

This has been a bug for a long time and I've constantly procrastinated
on fixing it but it was brought up when discussing Human AI bugs so I
went in to look around and found out what caused it, so I can finally
say I did it.

## Why It's Good For The Game

Security cameras no longer have infinite range.

## Changelog

:cl:
fix: Security camera consoles no longer have infinite range.
/:cl:

* Fixes sec computers having infinite distance

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: John Willard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants