Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TG Mirror] Fixes two improper calls to ADD_TRAIT (magic mirror, robo customer) #150

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24426
Original PR: tgstation/tgstation#79072

About The Pull Request

ADD_TRAIT doesn't take a list

Changelog

🆑 Melbert
fix: Magic Mirrors properly prevent you from being soft locked
fix: Robo customers are as robust as before
/:cl:

…stomer) [MDB IGNORE] (#24426)

* Fixes two improper calls to ADD_TRAIT (magic mirror, robo customer)  (#79072)

## About The Pull Request

`ADD_TRAIT` doesn't take a list

## Changelog

:cl: Melbert
fix: Magic Mirrors properly prevent you from being soft locked
fix: Robo customers are as robust as before
/:cl:

* Fixes two improper calls to ADD_TRAIT (magic mirror, robo customer)

---------

Co-authored-by: MrMelbert <[email protected]>
@Iajret Iajret merged commit 3cf2119 into master Oct 19, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-24426 branch October 19, 2023 20:11
Steals-The-PRs added a commit that referenced this pull request Oct 19, 2023
Iajret pushed a commit that referenced this pull request Jan 3, 2024
…150)

* Fixes AI behavior with breaking cuffs and resisting aggressive grabs (#80328)

## About The Pull Request

Makes it so that ai's recognize they're in a do_after after resisting,
preventing them from processing and interrupting the do_after while
they're in a condition that necessitates it. If it gets interrupted then
they'll process as normal, or if they finish they'll be free.
## Why It's Good For The Game

Monkeys can now resist things that they should've been, such as
aggressive grabs or cuffs, instead of having their ai completely freeze
when they're cuffed.
## Changelog
:cl:
fix: ai can now tell if it is in a do_after for resisting and will not
interrupt it. monkeys also now don't freeze up when aggressively grabbed
and will resist out of those and cuffs.
/:cl:

* Fixes AI behavior with breaking cuffs and resisting aggressive grabs

---------

Co-authored-by: Diamond_ <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants