Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Make list clear nulls faster #1509

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[MIRROR] Make list clear nulls faster #1509

merged 1 commit into from
Jan 11, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#392
Original PR: tgstation/tgstation#80869

The old version makes a new list of n null values, and removes it from the given list.

for larger lists, this newer 515 version should be faster and lead to less list churn.

image

* Make list clear nulls faster (#80869)

The old version makes a new list of n null values, and removes it from
the given list.

for larger lists, this newer 515 version should be faster and lead to
less list churn.

![image](https://github.com/tgstation/tgstation/assets/7069733/9c23cc8b-06c4-4a54-99b4-2c44608cf434)

* Make list clear nulls faster

---------

Co-authored-by: Kyle Spier-Swenson <[email protected]>
Co-authored-by: NovaBot <[email protected]>
@Iajret Iajret merged commit c06e979 into master Jan 11, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-392 branch January 11, 2024 22:42
Iajret pushed a commit that referenced this pull request Mar 18, 2024
* [NO GBP] Changelogs an undocumented change in #1478

* Update README.md

---------

Co-authored-by: Bloop <[email protected]>
ReezeBL pushed a commit that referenced this pull request Mar 20, 2024
* [NO GBP] Changelogs an undocumented change in #1478

* Update README.md

---------

Co-authored-by: Iamgoofball <[email protected]>
Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants