[TG Mirror] Fixes magic mirrors not being able to change your race (?) #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MDB IGNORE] (#24425) Fixes magic mirrors not being able to change your race (?) Co-authored-by: MrMelbert <[email protected]>
Steals-The-PRs
added a commit
that referenced
this pull request
Oct 19, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Micro-optimize qdel by only permitting one parameter (#80628) Productionizes #80615. The core optimization is this: ```patch - var/hint = to_delete.Destroy(arglist(args.Copy(2))) // Let our friend know they're about to get fucked up. + var/hint = to_delete.Destroy(force) // Let our friend know they're about to get fucked up. ``` We avoid a heap allocation in the form of copying the args over to a new list. A/B testing shows this results in 33% better overtime, and in a real round shaving off a full second of self time and 0.4 seconds of overtime--both of these would be doubled in the event this is merged as the new proc was only being run 50% of the time. * Micro-optimize qdel by only permitting one parameter * Modular updates * Find+replace fail --------- Co-authored-by: Mothblocks <[email protected]> Co-authored-by: NovaBot <[email protected]> Co-authored-by: Giz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24425
Original PR: tgstation/tgstation#79075
About The Pull Request
Not sure why this exactly was happening but I just changed around some vars and it fixed
Also it was assigning a qdeling datum to a mob. Bad bad bad
Changelog
🆑 Melbert
fix: Magic Mirrors can change your race again (?)
/:cl: