Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] SS14 Liquid Plasma Sprite #1532

Merged
merged 1 commit into from
Jan 14, 2024
Merged

[MIRROR] SS14 Liquid Plasma Sprite #1532

merged 1 commit into from
Jan 14, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#423
Original PR: tgstation/tgstation#80728

About The Pull Request

Replaces the "liquid plasma" sprite with SS14's modified one by mirrorcult

Why It's Good For The Game

The current liquid plasma sprite just looks like weirdly colored lava. SS14's one looks more like molten plasma

Before:
Screenshot 2024-01-02 200720

After:
Screenshot 2024-01-02 195947

Changelog

🆑 13spacemen
image: New liquid plasma sprites from SS14!
/:cl:

* SS14 Liquid Plasma Sprite (#80728)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Replaces the "liquid plasma" sprite with SS14's modified one by
mirrorcult
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
The current liquid plasma sprite just looks like weirdly colored lava.
SS14's one looks more like molten plasma

Before:
![Screenshot 2024-01-02
200720](https://github.com/tgstation/tgstation/assets/46101244/94a43f5c-91d4-4b33-b700-deba8c7d4e69)

After:
![Screenshot 2024-01-02
195947](https://github.com/tgstation/tgstation/assets/46101244/ff763dbb-799f-4a3e-8511-41aa089e1c87)

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl:
image: New liquid plasma sprites from SS14!
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

* SS14 Liquid Plasma Sprite

---------

Co-authored-by: 13spacemen <[email protected]>
Co-authored-by: NovaBot <[email protected]>
@Iajret Iajret merged commit b8889b6 into master Jan 14, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-423 branch January 14, 2024 09:33
AnywayFarus added a commit that referenced this pull request Jan 14, 2024
Iajret pushed a commit that referenced this pull request Mar 19, 2024
* Update piratefort.dmm

* Update syndibase.dmm
ReezeBL pushed a commit that referenced this pull request Mar 20, 2024
* Update piratefort.dmm

* Update syndibase.dmm

Co-authored-by: Sable <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants