[MIRROR] Futureproofs the nodrop check added in #80673 #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Futureproofs the nodrop check added in #80673 (#80722) ## About The Pull Request See #80673 I took a nap and got an idea how to make it better, so here we are Less snowflake code, very robust, very good Technically runs way more checks so it is slower but eh I believe it's worth it in this case Fully tested, it works as it should ## Changelog :cl: code: The check that prevents your stuff from dropping when you have robotic parts is now more robust /:cl: * Futureproofs the nodrop check added in #80673 --------- Co-authored-by: Waterpig <[email protected]> Co-authored-by: NovaBot <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 14, 2024
Iajret
pushed a commit
that referenced
this pull request
Mar 20, 2024
… deathmatch (#1536) * Suppresses excessive logging that results from fights in the deathmatch (#82096) ## About The Pull Request So this is a PR i have had testmerged downstream for like a month now because deathmatch SPAMS the hell out of admin logs. This makes doing admin work kinda annoying when all the useful logs are drowned out by people trying to smoke each other to death endlessly. I don't know how bad the problem is upstream, but I'd imagine TG admins would likely express the same gratitude to have less active logging in game, in the case something important happens that they need to see. This should still keep logging things to the actual log files so the logs will still exist, but this merely suppresses the massive spam of logs that admins actively see. ## Why It's Good For The Game Lets admins do their job a little bit better being able to see when things happen in the logs. Deathmatch logs can be rather disruptive towards admins. ## Changelog :cl: SomeRandomOwl admin: Deathmatch Bombs, Smoke, and Liquid floods are now suppressed in the logs and will not actively spam admin logs. code: adds a area flag to suppress logging for floods and bombs /:cl: * Suppresses excessive logging that results from fights in the deathmatch --------- Co-authored-by: SomeRandomOwl <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Mar 20, 2024
… deathmatch (#1536) (#2484) * Suppresses excessive logging that results from fights in the deathmatch (#82096) ## About The Pull Request So this is a PR i have had testmerged downstream for like a month now because deathmatch SPAMS the hell out of admin logs. This makes doing admin work kinda annoying when all the useful logs are drowned out by people trying to smoke each other to death endlessly. I don't know how bad the problem is upstream, but I'd imagine TG admins would likely express the same gratitude to have less active logging in game, in the case something important happens that they need to see. This should still keep logging things to the actual log files so the logs will still exist, but this merely suppresses the massive spam of logs that admins actively see. ## Why It's Good For The Game Lets admins do their job a little bit better being able to see when things happen in the logs. Deathmatch logs can be rather disruptive towards admins. ## Changelog :cl: SomeRandomOwl admin: Deathmatch Bombs, Smoke, and Liquid floods are now suppressed in the logs and will not actively spam admin logs. code: adds a area flag to suppress logging for floods and bombs /:cl: * Suppresses excessive logging that results from fights in the deathmatch --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#426
Original PR: tgstation/tgstation#80722
About The Pull Request
See #80673
I took a nap and got an idea how to make it better, so here we are
Less snowflake code, very robust, very good
Technically runs way more checks so it is slower but eh I believe it's worth it in this case
Fully tested, it works as it should
Changelog
🆑 Majkl-J
code: The check that prevents your stuff from dropping when you have robotic parts is now more robust
/:cl: