Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Opfor Improvements Pt 1, Wiki Buttons #1537

Closed
wants to merge 1 commit into from

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#360

About The Pull Request

This PR adds three buttons to the top section of the opfor panel. Respectively, they open the guide to getting your opfor approved, open the opfor section of antag policy, and open server rule 10 containing the non-criminal antag addendum.

Buttons will open these pages, specifically:
https://docs.google.com/document/u/0/d/e/2PACX-1vRVI8-SmicLDV7ny_8BwJ3s8nIYBPU-nhrFDNA95VQxfpmGeUWEuqsnHr1_YDBoEUYRSITEoUbnWlru/pub?pli=1
https://wiki.novasector13.com/index.php/Antagonist_Policy#Opfor_Related_Stuff:
https://wiki.novasector13.com/index.php/Server_Rules#Rule_10:_No_Self-Antagging

How This Contributes To The Nova Sector Roleplay Experience

Opfors can be an intimidating prospect to get into, especially for those not already familiar with vanilla antags. This PR aims to better communicate resources and policy to improve the quality of submitted opfors, and to lower the accessibility gap in making them.

Proof of Testing

Screenshots/Videos

opforimprovept1

Changelog

🆑 LovliestPlant
qol: In the Opfor panel, adds buttons to open Opfor Policy, the Non-Antag Criminal Addendum, and the Opfor Guide.
/:cl:

* The BEEF

* Swaps opfor guide button icon
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Jan 20, 2024
@Iajret Iajret removed the Stale label Jan 21, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Jan 29, 2024
@Iajret Iajret removed the Stale label Feb 4, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Feb 12, 2024
@github-actions github-actions bot closed this Feb 19, 2024
Iajret pushed a commit that referenced this pull request Mar 20, 2024
* Stops cluster grenades from spamming admins (#82090)

## About The Pull Request

Stops cluster grenades from logging their children.

## Why It's Good For The Game

Helps out with tgstation/tgstation#81865.

## Changelog

:cl:
admin: cluster bombs stop spamming admin logs
/:cl:

* Stops cluster grenades from spamming admins

---------

Co-authored-by: Bilbo367 <[email protected]>
ReezeBL pushed a commit that referenced this pull request Mar 20, 2024
* Stops cluster grenades from spamming admins (#82090)

## About The Pull Request

Stops cluster grenades from logging their children.

## Why It's Good For The Game

Helps out with tgstation/tgstation#81865.

## Changelog

:cl:
admin: cluster bombs stop spamming admin logs
/:cl:

* Stops cluster grenades from spamming admins

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Bilbo367 <[email protected]>
@AnywayFarus AnywayFarus deleted the upstream-mirror-360 branch June 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants