[MIRROR] Makes placing plating on lava-proof rods delete the rods and not break lighting on that tile for the rest of the round #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not break lighting on that tile for the rest of the round (#427) * Makes placing plating on lava-proof rods delete the rods and not break lighting on that tile for the rest of the round (#80876) ## About The Pull Request See title ## Why It's Good For The Game 1. Its a bit odd that the rods are still there and on top of the new tile you placed, considering you were build on top of them. 2. Because building didn't use place on top, the lighting on the tile would be broken and made entirely black for the rest of the round. Slightly annoying when you're constructing something on top of it! ## Changelog :cl: qol: The heat-proof catwalk made by heat-proof rods will go away when a tile is placed on it, rather than sticking around and needing to be removed manually fix: The lighting will not irreparably break on tiles where plating was placed on lava-proof catwalks code: Some single letter variables and the structure of the code around placing tiles on lava-proof catwalks has been improved /:cl: * Makes placing plating on lava-proof rods delete the rods and not break lighting on that tile for the rest of the round --------- Co-authored-by: Paxilmaniac <[email protected]> Co-authored-by: NovaBot <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 14, 2024
Iajret
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Infrared Emitters use beam datums (As God intended) (#82094) ## About The Pull Request Fixes #64459 Fixes #82052 , probably Fixes #79747 , probably Fixes #81443 Infrared emitters now use beam datums instead of making their own effects and trying to `Move` it out until it hits something This means 1. Infrared emitters are (probably) more responsive 2. Infrared emitters (probably) react to less things they shouldn't react to (such as projectiles) This also means - Infrared emitters (when visible) are emissive (and glow in the dark slightly). Kinda neat? If you don't want it you can obviously just make it invisible - You can limbo under beams? Maybe you can do that already? IDK Other notes - Beams no longer set their beam component's `x`, `y` directly, now using `forceMove`   https://github.com/tgstation/tgstation/assets/51863163/29b76b58-ef36-4c4a-a3b2-017b625389dd ## Changelog :cl: Melbert refactor: Infrared emitters now function better (or at least more how you would expect them) (hopefully). Report any oddities /:cl: * Infrared Emitters use beam datums (As God intended) --------- Co-authored-by: MrMelbert <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Mar 20, 2024
…2486) * Infrared Emitters use beam datums (As God intended) (#82094) ## About The Pull Request Fixes #64459 Fixes #82052 , probably Fixes #79747 , probably Fixes #81443 Infrared emitters now use beam datums instead of making their own effects and trying to `Move` it out until it hits something This means 1. Infrared emitters are (probably) more responsive 2. Infrared emitters (probably) react to less things they shouldn't react to (such as projectiles) This also means - Infrared emitters (when visible) are emissive (and glow in the dark slightly). Kinda neat? If you don't want it you can obviously just make it invisible - You can limbo under beams? Maybe you can do that already? IDK Other notes - Beams no longer set their beam component's `x`, `y` directly, now using `forceMove`   https://github.com/tgstation/tgstation/assets/51863163/29b76b58-ef36-4c4a-a3b2-017b625389dd ## Changelog :cl: Melbert refactor: Infrared emitters now function better (or at least more how you would expect them) (hopefully). Report any oddities /:cl: * Infrared Emitters use beam datums (As God intended) --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#427
Original PR: tgstation/tgstation#80876
About The Pull Request
See title
Why It's Good For The Game
Changelog
🆑 Paxilmaniac
qol: The heat-proof catwalk made by heat-proof rods will go away when a tile is placed on it, rather than sticking around and needing to be removed manually
fix: The lighting will not irreparably break on tiles where plating was placed on lava-proof catwalks
code: Some single letter variables and the structure of the code around placing tiles on lava-proof catwalks has been improved
/:cl: