Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes there being 3 progressbars when welding self as a synth #1542

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#432

About The Pull Request

Now there is only one.

Fixes NovaSector/NovaSector#430

Proof of Testing

Screenshots/Videos

dreamseeker_OjpcYCTh5x

Changelog

🆑 vinylspiders
fix: welding self as synth no longer makes you suffer through 3 progressbars
/:cl:

@Iajret Iajret merged commit ad394a7 into master Jan 14, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-432 branch January 14, 2024 09:37
AnywayFarus added a commit that referenced this pull request Jan 14, 2024
Iajret pushed a commit that referenced this pull request Mar 20, 2024
… of the vending refill required. (#1542)

* [No GBP] Vending examine message now properly shows the name of the vending refill required. (#82101)

## About The Pull Request

Vending refills were piping in the typepath of the refill as opposed to
the name since their examine was referencing a type path. This instead
pulls the `machine_name` and `name` to form the correct string on
examine to confirm that the value is accurate.

![image](https://github.com/tgstation/tgstation/assets/41715314/88db4bb7-a529-4dee-bd9e-e83ff4b66b9a)

## Why It's Good For The Game
Fixes #82095. That should probably not be shown in-game as is and now
actually showcases the correct message on examine.

## Changelog
:cl:
fix: Vending machines now show the correct vending refill name when
examine and not full.
/:cl:

* [No GBP] Vending examine message now properly shows the name of the vending refill required.

---------

Co-authored-by: ArcaneMusic <[email protected]>
ReezeBL pushed a commit that referenced this pull request Mar 22, 2024
… of the vending refill required. (#1542) (#2489)

* [No GBP] Vending examine message now properly shows the name of the vending refill required. (#82101)

## About The Pull Request

Vending refills were piping in the typepath of the refill as opposed to
the name since their examine was referencing a type path. This instead
pulls the `machine_name` and `name` to form the correct string on
examine to confirm that the value is accurate.

![image](https://github.com/tgstation/tgstation/assets/41715314/88db4bb7-a529-4dee-bd9e-e83ff4b66b9a)

## Why It's Good For The Game
Fixes #82095. That should probably not be shown in-game as is and now
actually showcases the correct message on examine.

## Changelog
:cl:
fix: Vending machines now show the correct vending refill name when
examine and not full.
/:cl:

* [No GBP] Vending examine message now properly shows the name of the vending refill required.

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: ArcaneMusic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

there's 3 progress bars when you weld yourself as a synth
3 participants