Fixes ai shell deployment not unregistering a death signal properly #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperly [MDB IGNORE] (#24444)
* Fixes ai shell deployment not unregistering a death signal properly (#78816)
it was screaming runtimes each time an ai disconnected or reconnected to
an ai shell because it never unregistered the death disconnect signal
properly.
```
[2023-10-01 14:56:38.191] RUNTIME: runtime error: living_death overridden. Use override = TRUE to suppress this warning.
- Target: Calaban Default Shell-980 (/mob/living/silicon/robot/shell) Proc: disconnect_shell (code/datums/signals.dm:39)
- proc name: stack trace (/proc/_stack_trace)
- source file: code/__HELPERS/stack_trace.dm,4
- usr: Calaban (/mob/living/silicon/ai)
- src: null
- usr.loc: the floor (150,25,4) (/turf/open/floor/circuit)
- call stack:
- stack trace("living_death overridden. Use o...", "code/datums/signals.dm", 39)
- Calaban (/mob/living/silicon/ai): RegisterSignal(Calaban Default Shell-980 (/mob/living/silicon/robot/shell), "living_death", "disconnect_shell", 0)
- Calaban (/mob/living/silicon/ai): Deploy to Shell(Calaban Default Shell-980 (/mob/living/silicon/robot/shell))
- Reconnect to shell (/datum/action/innate/deploy_last_shell): Trigger(null)
- Reconnect to shell (/atom/movable/screen/movable/action_button): Click(null, "mapwindow.map", "icon-x=12;icon-y=17;left=1;but...")
- Reconnect to shell (/atom/movable/screen/movable/action_button): Click(null, "mapwindow.map", "icon-x=12;icon-y=17;left=1;but...")
- /datum/callback/verb_callback (/datum/callback/verb_callback): Invoke()
- world: push usr(Calaban (/mob/living/silicon/ai), /datum/callback/verb_callback (/datum/callback/verb_callback))
- /datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync()
- Input (/datum/controller/subsystem/verb_manager/input): run verb queue()
- Input (/datum/controller/subsystem/verb_manager/input): fire(0)
- Input (/datum/controller/subsystem/verb_manager/input): fire(0)
- Input (/datum/controller/subsystem/verb_manager/input): fire(0)
- Input (/datum/controller/subsystem/verb_manager/input): ignite(0)
- Master (/datum/controller/master): RunQueue()
- Master (/datum/controller/master): Loop(2)
- Master (/datum/controller/master): StartProcessing(0)
```
shouldn't be player facing i think but who knows maybe we've missed
something here on an empty shell death. ai eye resets to the shell's
position? no clue lmao it was just fucking annoying
* Fixes ai shell deployment not unregistering a death signal properly
---------
Co-authored-by: Sealed101 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24444
Original PR: tgstation/tgstation#78816
it was screaming runtimes each time an ai disconnected or reconnected to an ai shell because it never unregistered the death disconnect signal properly.
shouldn't be player facing i think but who knows maybe we've missed something here on an empty shell death. ai eye resets to the shell's position? no clue lmao it was just fucking annoying