[MIRROR] Change how a station trait is declared abstract (#80268) #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how a station trait is declared abstract (#80268) @Fikou requested this and it seemed like a good idea. This change the pattern for "how we declare that we don't want a station trait to actually exist" from "it's a bitfield" to the other commonly-used pattern of "it's a var which points at a typepath". The purpose of doing this is that most of the station traits which have an abstract parent want the default `trait_flags` value of their grandparent and have to redeclare it for no reason, which becomes more tedious the more children there are. This means that you don't need to do that because the `abstract_type` var will only evaluate to true when checked on the specified abstract type, without needing to change its value on any children. Makes extending traits marginally easier not player facing Co-authored-by: Jacquerel <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-390
Iajret
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Fix puzzlegrids not reporting their answer (#82213) ## About The Pull Request `src` is a a datum, so `get_hearers_in_view` fails ## Changelog :cl: Melbert fix: Puzzlegrids now report their answers properly /:cl: * Fix puzzlegrids not reporting their answer --------- Co-authored-by: MrMelbert <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Fix puzzlegrids not reporting their answer (#82213) ## About The Pull Request `src` is a a datum, so `get_hearers_in_view` fails ## Changelog :cl: Melbert fix: Puzzlegrids now report their answers properly /:cl: * Fix puzzlegrids not reporting their answer --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#390
ORIGINAL PR: tgstation/tgstation@659a343
@Fikou requested this and it seemed like a good idea. This change the pattern for "how we declare that we don't want a station trait to actually exist" from "it's a bitfield" to the other commonly-used pattern of "it's a var which points at a typepath". The purpose of doing this is that most of the station traits which have an abstract parent want the default
trait_flagsvalue of their grandparent and have to redeclare it for no reason, which becomes more tedious the more children there are. This means that you don't need to do that because theabstract_typevar will only evaluate to true when checked on the specified abstract type, without needing to change its value on any children.Makes extending traits marginally easier
not player facing