Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrows can be converted #169

Merged
merged 1 commit into from
Oct 20, 2023
Merged

arrows can be converted #169

merged 1 commit into from
Oct 20, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24449

About The Pull Request

adds the ability to transform arrows to different types by attacking them with the conversion item (bronze tile to bronze arrow, bone to bone arrow, and sinew to ash arrow).

I also removed the forged arrow subtype-- after some well needed qol PRs, they became unused and not necessary.

THIS DOES NOT REMOVE THE RECIPES-- there may be cases where you need to be able to craft them so I kept the recipes.

How This Contributes To The Skyrat Roleplay Experience

Rather than being stuck in the crafting menu, more item interactions like this keeps "immersion."

Proof of Testing

Screenshots/Videos

image

Changelog

🆑 jjpark-kb
add: you can change arrows into different types by hitting them with the conversion item (bronze tile for bronze, bone for bone, and sinew for ash)
del: removes the forged arrow subtype
/:cl:

* arrows can be converted

* Update modular_skyrat/modules/reagent_forging/code/forge_weapons.dm

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: Bloop <[email protected]>
@AnywayFarus AnywayFarus merged commit 3ce838a into master Oct 20, 2023
23 checks passed
@AnywayFarus AnywayFarus deleted the upstream-mirror-24449 branch October 20, 2023 10:30
AnywayFarus added a commit that referenced this pull request Oct 20, 2023
Iajret pushed a commit that referenced this pull request Jan 3, 2024
* Emergency DMAPI fix for downstreams still on TGS5 (#80653)

There was a double version bump on two branches that got merged, this
feature flag should be in 8

* Emergency DMAPI fix for downstreams still on TGS5

---------

Co-authored-by: Jordan Dominion <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants