[MIRROR] northstar mail sorting room access and door nitpick #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* northstar mail sorting room access and door nitpick (#81179) ## About The Pull Request back from the grave for yet another minor access nitpick that was brought to my attention. northstars mail room had an awkward access woopsy attached to it, from the screenshot here you can see the top right door uses all mining access for some unknown reason, i'm assuming that this was simply forgotten in a rework of the department so i'm fixing it as it was shown to me in a dream (a cargo player told me it irritated them and others).  i also went ahead and replaced the door it used to also use the mail sorting room door that the top uses, as it was originally using the mining decontamination room door, which is another reason i was thinkin' it got reworked and overlooked, as the decontamination rooms just four tiles above it and uses high security doors. the actual access changes made were that i removed the all/supply/mining access required on the door and gave it any/supply/general, mining, and bitden, along with replacing the top doors access with any/supply/general, mining, and bitden access so people who get jobchanged into a cargo job have an easier time actually getting in in case the HoP forgets, i factchecked this with delta and a couple of other maps, which split the idea because delta does what i'm doing, but maps like meta and icebox use all/supply/general and nothing else, so if anyone has any problems with this i can change it to all/supply/general, i just view this as a safer bet for people who might get jobchanged by the HoP whos playing clash royale while filing ID accesses. ## Why It's Good For The Game i don't see a point to having two separate doors for the same room to have different access restrictions when both doors also come from the same room, plus the door being named mining decontamination when it doesn't lead into mining decontamination anymore irks me now that i saw it and it must be changed or else i will weep. the access changes for the doors allows people who get jobchanges into the department an easier time if for some reason they needed to keep access from their previous job but can't fit everything, for instance a slow round for a psych who wants to game but keep psych access. ## Changelog :cl: fix: the top and top righthand doors of northstars cargo mail sorting room now use any supply general, mining, and bitden access, and the top righthand door no longer says its mining decontamination and uses the proper mail sorting room airlock instead. /:cl: * northstar mail sorting room access and door nitpick --------- Co-authored-by: Donglesplonge <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 6, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 3, 2024
…1777) * Merge ordinance burn chamber with main lab for MetaStation (#82322) ## About The Pull Request Fixes the issue specified in #82294 for Metastation ordinance burn chamber. Now both the burn chamber and the lab are combined together as one area(no physical objects were displaced just their area properties were modified) so they share the same apc allowing the igniter to function there ## Changelog :cl: fix: igniter in meta station ordinance burn chamber works again /:cl: * Merge ordinance burn chamber with main lab for MetaStation --------- Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#712
Original PR: tgstation/tgstation#81179
About The Pull Request
back from the grave for yet another minor access nitpick that was brought to my attention.
northstars mail room had an awkward access woopsy attached to it, from the screenshot here you can see the top right door uses all mining access for some unknown reason, i'm assuming that this was simply forgotten in a rework of the department so i'm fixing it as it was shown to me in a dream (a cargo player told me it irritated them and others).
i also went ahead and replaced the door it used to also use the mail sorting room door that the top uses, as it was originally using the mining decontamination room door, which is another reason i was thinkin' it got reworked and overlooked, as the decontamination rooms just four tiles above it and uses high security doors.
the actual access changes made were that i removed the all/supply/mining access required on the door and gave it any/supply/general, mining, and bitden, along with replacing the top doors access with any/supply/general, mining, and bitden access so people who get jobchanged into a cargo job have an easier time actually getting in in case the HoP forgets, i factchecked this with delta and a couple of other maps, which split the idea because delta does what i'm doing, but maps like meta and icebox use all/supply/general and nothing else, so if anyone has any problems with this i can change it to all/supply/general, i just view this as a safer bet for people who might get jobchanged by the HoP whos playing clash royale while filing ID accesses.
Why It's Good For The Game
i don't see a point to having two separate doors for the same room to have different access restrictions when both doors also come from the same room, plus the door being named mining decontamination when it doesn't lead into mining decontamination anymore irks me now that i saw it and it must be changed or else i will weep. the access changes for the doors allows people who get jobchanges into the department an easier time if for some reason they needed to keep access from their previous job but can't fit everything, for instance a slow round for a psych who wants to game but keep psych access.
Changelog
🆑 Donglesplonge
fix: the top and top righthand doors of northstars cargo mail sorting room now use any supply general, mining, and bitden access, and the top righthand door no longer says its mining decontamination and uses the proper mail sorting room airlock instead.
/:cl: