Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes Cult voting for a leader #1780

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#713
Original PR: tgstation/tgstation#81169

About The Pull Request

With the recent changes to polling, it seems like it didn't properly poll cultists, I fixed that and fixed other issues with it (such as it telling players that they are signing up to BE a cult leader, when they arent).

Also fixed the button to put yourself forward as cult leader, it properly removes and gives itself when necessary.

Why It's Good For The Game

Cult button works again how cool is that

Closes tgstation/tgstation#80620

Changelog

🆑 JohnFulpWillard
fix: Cultists can now vote for a Cult leader again.
/:cl:

* Fixes Cult voting for a leader (#81169)

## About The Pull Request

With the recent changes to polling, it seems like it didn't properly
poll cultists, I fixed that and fixed other issues with it (such as it
telling players that they are signing up to BE a cult leader, when they
arent).

Also fixed the button to put yourself forward as cult leader, it
properly removes and gives itself when necessary.

## Why It's Good For The Game

Cult button works again how cool is that

Closes tgstation/tgstation#80620

## Changelog

:cl:
fix: Cultists can now vote for a Cult leader again.
/:cl:

* Fixes Cult voting for a leader

---------

Co-authored-by: John Willard <[email protected]>
@ReezeBL ReezeBL merged commit 4b60813 into master Feb 6, 2024
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-713 branch February 6, 2024 07:46
AnywayFarus added a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New voting means that you can't pick a cult leader (or it's at least weirder than before?)
3 participants