Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Mech wire panels can no longer be accessed while the mech is occupied. #1784

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#720
Original PR: tgstation/tgstation#81194

About The Pull Request

  • The screwdriver_act() proc is blocked if the mech's occupant list isn't empty.
  • Entering a mech also force-sets the panel closed.
  • Fixes an incorrect comment.

Why It's Good For The Game

I think mech wires were dumb to begin with, but that's not the hill I'm here to die on today.

The ability to mess with mech wires while the mech is piloted doesn't really make anti-mech combat better. Pilot gets a big giant text warning, if they're looking at the text window, but if not the wires can be quick-snipped once the do-after is done. If you were in the middle of typing, you have a short window to close the text box and get back to moving before the panel is open (and you cannot close it without exiting the mech). At the same time, there's no real way to combo into it, so it's only really useful against mechs otherwise distracted, or as cheese when the mech is in a corner. Then we put things like weapon disabling and forced overclocking (and thus, damage) into the wires, so cutting everything cripples the vehicle.

In short, it's stupid powerful when it works, and yet it only works against inattentive players unaware of the mech wire system. An overly cheesy anti-mech strat when the go-to should be EMPs.

You can still steal unoccupied mechs, I guess, go nuts.

Changelog

🆑 zxaber
balance: Mech wire panels are now blocked when the mech is occupied. I guess it was moved to be behind the seat.
/:cl:

… occupied. (#720)

* Mech wire panels can no longer be accessed while the mech is occupied. (#81194)

## About The Pull Request
- The screwdriver_act() proc is blocked if the mech's occupant list
isn't empty.
- Entering a mech also force-sets the panel closed.
- Fixes an incorrect comment.
## Why It's Good For The Game
I think mech wires were dumb to begin with, but that's not the hill I'm
here to die on today.

The ability to mess with mech wires while the mech is piloted doesn't
really make anti-mech combat better. Pilot gets a big giant text
warning, if they're looking at the text window, but if not the wires can
be quick-snipped once the do-after is done. If you were in the middle of
typing, you have a short window to close the text box and get back to
moving before the panel is open (and you cannot close it without exiting
the mech). At the same time, there's no real way to combo into it, so
it's _only_ really useful against mechs otherwise distracted, or as
cheese when the mech is in a corner. Then we put things like weapon
disabling and forced overclocking (and thus, damage) into the wires, so
cutting everything cripples the vehicle.

In short, it's stupid powerful when it works, and yet it only works
against inattentive players unaware of the mech wire system. An overly
cheesy anti-mech strat when the go-to should be EMPs.

You can still steal unoccupied mechs, I guess, go nuts.
## Changelog
:cl:
balance: Mech wire panels are now blocked when the mech is occupied. I
guess it was moved to be behind the seat.
/:cl:

* Mech wire panels can no longer be accessed while the mech is occupied.

---------

Co-authored-by: zxaber <[email protected]>
@ReezeBL ReezeBL merged commit 9d75902 into master Feb 6, 2024
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-720 branch February 6, 2024 07:48
AnywayFarus added a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants