[MIRROR] Fixes runtime from examining mod PCs #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes runtime from examining mod PCs (#81200) ## About The Pull Request It's a classic  `EXAMINE_HINT(x)` resolves to `"<b>" + x + "</b>"` When placed in this line directly, you get: `["<b>" + HAS_TRAIT_FROM(...) ? "..." : "..." + "</b>"]` You see the issue, right? This resolves as you would expect: `("<b>" + HAS_TRAIT_FROM(...)) ? ("...") : ("..." + "</b>")` Which, of course, runtimes as it's adding a string to an integer (0). By pulling it out to its own var we can get around this: `["<b>" + frame_or_pc + "</b>"]` ## Changelog :cl: Melbert fix: Fixed examining modular PCs /:cl: * Fixes runtime from examining mod PCs --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 6, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 3, 2024
* TGUI: updated dependencies * Fixing conflicts, lock file --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#724
Original PR: tgstation/tgstation#81200
About The Pull Request
It's a classic
EXAMINE_HINT(x)resolves to"<b>" + x + "</b>"When placed in this line directly, you get:
["<b>" + HAS_TRAIT_FROM(...) ? "..." : "..." + "</b>"]You see the issue, right?
This resolves as you would expect:
("<b>" + HAS_TRAIT_FROM(...)) ? ("...") : ("..." + "</b>")Which, of course, runtimes as it's adding a string to an integer (0).
By pulling it out to its own var we can get around this:
["<b>" + frame_or_pc + "</b>"]Changelog
🆑 Melbert
fix: Fixed examining modular PCs
/:cl: