[MIRROR] Bit of reference handling for custom food holders #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bit of reference handling for custom food holders (#81195) ## About The Pull Request `ingredients` seems to hold a reference to all the food in our atom's contents that are used to make up our custom food, but it doesn't clear it anywhere. So I implemented `Exited`, as well as cutting the list on component `Destroy`. * Bit of reference handling for custom food holders --------- Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 3, 2024
…ion (#81770) (#1789) Bumps up several GitHub `actions` to the Node 20 Version (#81770) Node 16 actions are deprecated, we need to use Node 20 actions now (as noted by this handy screenshot which spams it on every CI run)  You may see https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ for more information. Co-authored-by: san7890 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#728
Original PR: tgstation/tgstation#81195
About The Pull Request
ingredientsseems to hold a reference to all the food in our atom's contents that are used to make up our custom food, but it doesn't clear it anywhere.So I implemented
Exited, as well as cutting the list on componentDestroy.