[MIRROR] Fix robotic voicebox tongue using the wrong proc. #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix robotic voicebox tongue using the wrong proc. (#81206) ## About The Pull Request The robotic voicebox tongue had the `can_speak_language(language)` proc set to return `TRUE` regardless, however it doesn't seem like this is actually called on a tongue anywhere else in the code. I _believe_ this proc is on the atom level, and isn't for the tongue itself. I think the correct proc would be `could_speak_language(datum/language/language_path)`. which is defined on the tongue and most importantly actually called when checking which language a carbon can speak. ```dm /mob/living/carbon/could_speak_language(datum/language/language_path) var/obj/item/organ/internal/tongue/spoken_with = get_organ_slot(ORGAN_SLOT_TONGUE) // the tower of babel needs to bypass the tongue language restrictions without giving omnitongue return HAS_MIND_TRAIT(src, TRAIT_TOWER_OF_BABEL) || spoken_with.could_speak_language(language_path) ``` ## Why It's Good For The Game It having `can_speak_language(language)` doesn't seem to actually be doing anything, but its presence in the first place makes me feel like this is unintentional. This fixes that. ## Changelog :cl: fix: Robotic voicebox actually lets you speak any language again (as long as you know it). /:cl: * Fix robotic voicebox tongue using the wrong proc. --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 6, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#738
Original PR: tgstation/tgstation#81206
About The Pull Request
The robotic voicebox tongue had the
can_speak_language(language)proc set to returnTRUEregardless, however it doesn't seem like this is actually called on a tongue anywhere else in the code. I believe this proc is on the atom level, and isn't for the tongue itself.I think the correct proc would be
could_speak_language(datum/language/language_path). which is defined on the tongue and most importantly actually called when checking which language a carbon can speak.Why It's Good For The Game
It having
can_speak_language(language)doesn't seem to actually be doing anything, but its presence in the first place makes me feel like this is unintentional. This fixes that.Changelog
🆑 00-Steven
fix: Robotic voicebox actually lets you speak any language again (as long as you know it).
/:cl: