[MIRROR] Fix /datum/ui_state/greyscale_menu_state for non-atom datums
#1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms (#791) * Fix `/datum/ui_state/greyscale_menu_state` for non-atom datums (#81310) ## About The Pull Request `can_use_topic` returns a UI define like `UI_INTERACTIVE`, not `TRUE` / `FALSE` This line is intended to allow greyscale menus to be used when targeting non-atoms, however it prevents that entirely. #77322 ## Changelog Not necessary since _we_ don't have any GAGS menu usage that targets a datum... currently. * Fix `/datum/ui_state/greyscale_menu_state` for non-atom datums --------- Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 7, 2024
* Medipens can't have reagents removed from them anymore. (#82451) ## About The Pull Request This will be needed for tgstation/tgstation#82449 because this removes the machine's ability to make infinite chems. Basically in tgstation/tgstation#29139 they removed medipen's ability to have reagents injected into them, but never removed the ability to take reagents out. You could take a syringe, remove all chemicals from a medipen, put the main ingredient in a medipen refiller, then refill. You could do this right now on live servers with an epipen for infinite formaldehyde. This doesn't affect the hypospray. ## Why It's Good For The Game Removes a way of infinitely making reagents with a medipen refiller and also removes a dumb mechanic. You could take all chemicals out of an EHMS autoinjector, which removes the visual and feedback tell to the target that they've been injected, and even with 0 chemicals they get the disease anyways. You could buy medipens as a miner, take the chemicals out, and put them in a syringe or pill that you can inject yourself instantly with. You can take otherwise hard-to-get chemicals like fungal TB's 2-use cure injector, and make 40 cure pills instead. ## Changelog :cl: fix: You can no longer take chemicals out of medipens with a syringe. /:cl: * Medipens can't have reagents removed from them anymore. --------- Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#791
Original PR: tgstation/tgstation#81310
About The Pull Request
can_use_topicreturns a UI define likeUI_INTERACTIVE, notTRUE/FALSEThis line is intended to allow greyscale menus to be used when targeting non-atoms, however it prevents that entirely. #77322
Changelog
Not necessary since we don't have any GAGS menu usage that targets a datum... currently.