Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Gives paradox clone their own ghost polling icon #1836

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#804
Original PR: tgstation/tgstation#81229

About The Pull Request

Currently all ghost roles, when polling for players, shows a syndicate poster. This is lame as hell, especially since most of the roles aren't even Syndicate aligned.
This adds support to have your own icons for it, and adds one for the Paradox clone since I already had an idea for it.

Why It's Good For The Game

Paradox clones are not syndicate aligned and it does not make sense to portray that to players, this looks much better, and hopefully soon other antags will follow suite.
image

Changelog

🆑 JohnFulpWillard
add: Paradox clones now have a bluespace stream instead of a syndicate poster as their ghost poll icon.
/:cl:

* Gives paradox clone their own ghost polling icon (#81229)

## About The Pull Request

Currently all ghost roles, when polling for players, shows a syndicate
poster. This is lame as hell, especially since most of the roles aren't
even Syndicate aligned.
This adds support to have your own icons for it, and adds one for the
Paradox clone since I already had an idea for it.

## Why It's Good For The Game

Paradox clones are not syndicate aligned and it does not make sense to
portray that to players, this looks much better, and hopefully soon
other antags will follow suite.

![image](https://github.com/tgstation/tgstation/assets/53777086/b6016ff1-9914-42a8-bd9f-e72ba5539e11)

## Changelog

:cl:
add: Paradox clones now have a bluespace stream instead of a syndicate
poster as their ghost poll icon.
/:cl:

* Gives paradox clone their own ghost polling icon

---------

Co-authored-by: John Willard <[email protected]>
@Iajret Iajret merged commit 8406254 into master Feb 7, 2024
24 checks passed
AnywayFarus added a commit that referenced this pull request Feb 7, 2024
@Iajret Iajret deleted the upstream-mirror-804 branch February 7, 2024 23:31
Iajret pushed a commit that referenced this pull request Apr 7, 2024
* Fix slime `check_item_passthrough` effect (#82484)

## About The Pull Request

This proc expects a user but is not passed one. 

## Changelog

:cl: Melbert
fix: Items will properly pass through slime on occasion
/:cl:

* Fix slime `check_item_passthrough` effect

---------

Co-authored-by: MrMelbert <[email protected]>
mogeoko pushed a commit that referenced this pull request Apr 7, 2024
* Fix slime `check_item_passthrough` effect (#82484)

## About The Pull Request

This proc expects a user but is not passed one. 

## Changelog

:cl: Melbert
fix: Items will properly pass through slime on occasion
/:cl:

* Fix slime `check_item_passthrough` effect

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants