Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes scream for me, and also fixes literally EVERY INSTANCE of non-random puncture wounds #184

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24460
Original PR: tgstation/tgstation#79043

About The Pull Request

Closes tgstation/tgstation#79017

So turns out, I

  1. Had a pair of inverted more/less than operators in a crucial area. I DONT KNOW HOW THIS WORKED. SHIT is a FUCKING mystery.
  2. Used a non-existant define which DM converted into a string because Byond

Why It's Good For The Game

bugsgs badagfd

Changelog

🆑 nikothedude
fix: Scream for me, the spell, now works
fix: Non-random puncture wounds can now be applied
/:cl:

… INSTANCE of non-random puncture wounds [MDB IGNORE] (#24460)

* [NO GBP] Fixes scream for me, and also fixes literally EVERY INSTANCE of non-random puncture wounds

* Update wounds.dm

* Update wounds.dm

* Update wounds.dm

* Update wounds.dm

---------

Co-authored-by: nikothedude <[email protected]>
Co-authored-by: Bloop <[email protected]>
@AnywayFarus AnywayFarus merged commit 2d05304 into master Oct 20, 2023
23 checks passed
@AnywayFarus AnywayFarus deleted the upstream-mirror-24460 branch October 20, 2023 19:13
AnywayFarus added a commit that referenced this pull request Oct 20, 2023
Iajret pushed a commit that referenced this pull request Jan 3, 2024
* Cleans up some extra args in Destroy() (#80642)

## About The Pull Request

After tgstation/tgstation#80628, these shouldn't
be needed anymore right?

## Why It's Good For The Game

Cleans up some vestigial code

## Changelog
EDIT: Not player-facing.

* Cleans up some extra args in Destroy()

---------

Co-authored-by: Bloop <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCREAM FOR ME DOESN'T WORK, WOUND REFACTOR BROKE IT
3 participants