Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] autolathe altclick sanity #1844

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[MIRROR] autolathe altclick sanity #1844

merged 1 commit into from
Feb 7, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#820
Original PR: tgstation/tgstation#81267

About The Pull Request

you may no longer reset drop direction at range and stuff

Why It's Good For The Game

bug bad

Changelog

🆑 mc-oofert
fix: you may no longer reset autolathe drop direction at times when you shouldnt be able to
/:cl:

* autolathe altclick sanity (#81267)

## About The Pull Request

you may no longer reset drop direction at range and stuff

## Why It's Good For The Game

bug bad

## Changelog
:cl:
fix: you may no longer reset autolathe drop direction at times when you
shouldnt be able to
/:cl:

* autolathe altclick sanity

---------

Co-authored-by: jimmyl <[email protected]>
@Iajret Iajret merged commit 6ed1bd9 into master Feb 7, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-820 branch February 7, 2024 23:29
AnywayFarus added a commit that referenced this pull request Feb 8, 2024
Iajret pushed a commit that referenced this pull request Apr 7, 2024
* Fix captive xeno roundend report runtime (#82490)

## About The Pull Request

`check_captivity` accepts a mob, not a mind


![image](https://github.com/tgstation/tgstation/assets/51863163/77952d56-8142-4bbc-8042-028dcb39a989)

Which leads me to believe this always returned `null` and always failed.

But checking further and this proc does not return a truthy or falsy
value at all, meaning even if this runtime didn't happen, it still
wouldn't function correctly. So I made it check for `CAPTIVE_XENO_PASS`.

## Changelog

:cl: Melbert
fix: Captive Xeno end round report should make a tad more sense
/:cl:

* Fix captive xeno roundend report runtime

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants