[MIRROR] Machinery cannot be interacted with by AI when its turf is off-camera #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ff-camera (#822) * Machinery cannot be interacted with by AI when its turf is off-camera (#81250) ## About The Pull Request When an AI interacts with a machine, it will now check if the turf it occupies is on the cameranet. This should ensure that wallmounted machinery shouldn't be accessible from the other side of a wall. This image summarizes what this applies to:  Blue APC should be visible. Red should not. Normally, if red is covered completely by static, it becomes inaccessible. The red APC remaining visible is only the result of the perspective. We can't black out the entire wall when it goes off-camera since it can still be seen from the other side. The blue APC is technically stationed on a turf in a different room and is the only one in camera view, which would also be blocked out and would be needlessly inaccessible. Walls that remain in view from only one "side" of the wall, have all of their wallmounts accessible to the AI despite not (logically) having a camera pointed at them. Damn, when is the wallening gonna get here? Anyways, since the AI cam is a top-down view that only technically respects cameras, you see things you aren't supposed to see. We can't solve it by covering the entire tile, or leaving it uncovered, so this is the best we got. I got mixed up looking for where exactly to put this check. There might be a better solution for this but I do not see it at the moment. ## Why It's Good For The Game Wallmounts being accessible due to loopholes in perspective makes things confusing for players who don't see the world the same way. It would also be dishonest of me not to mention why I started on this PR, and why this is marked as a balance PR - This was done to un-jank the pain of doing console hack objectives. It's a bit nonsensical to have to take out cameras on the other side of a wall just to make sure your APC doesn't get powered down. ## Changelog :cl: Rhials balance: Wallmounts now respect cameranets, and cannot be accessed from a view of the adjacent wall. /:cl: * Machinery cannot be interacted with by AI when its turf is off-camera --------- Co-authored-by: Rhials <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 8, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 7, 2024
* Fix `/datum/dimension_theme/fancy` never applying (#82485) ## About The Pull Request It always runtimed due to `replace_floors` being `null` and because it runtimed it never got to set `replace_floors` to a list ## Changelog :cl: Melbert fix: Fix fancy anomaly theme being broken /:cl: * Fix `/datum/dimension_theme/fancy` never applying --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#822
Original PR: tgstation/tgstation#81250
About The Pull Request
When an AI interacts with a machine, it will now check if the turf it occupies is on the cameranet. This should ensure that wallmounted machinery shouldn't be accessible from the other side of a wall.
This image summarizes what this applies to:
Blue APC should be visible. Red should not. Normally, if red is covered completely by static, it becomes inaccessible. The red APC remaining visible is only the result of the perspective. We can't black out the entire wall when it goes off-camera since it can still be seen from the other side. The blue APC is technically stationed on a turf in a different room and is the only one in camera view, which would also be blocked out and would be needlessly inaccessible. Walls that remain in view from only one "side" of the wall, have all of their wallmounts accessible to the AI despite not (logically) having a camera pointed at them.
Damn, when is the wallening gonna get here?
Anyways, since the AI cam is a top-down view that only technically respects cameras, you see things you aren't supposed to see. We can't solve it by covering the entire tile, or leaving it uncovered, so this is the best we got.
I got mixed up looking for where exactly to put this check. There might be a better solution for this but I do not see it at the moment.
Why It's Good For The Game
Wallmounts being accessible due to loopholes in perspective makes things confusing for players who don't see the world the same way.
It would also be dishonest of me not to mention why I started on this PR, and why this is marked as a balance PR - This was done to un-jank the pain of doing console hack objectives. It's a bit nonsensical to have to take out cameras on the other side of a wall just to make sure your APC doesn't get powered down.
Changelog
🆑 Rhials
balance: Wallmounts now respect cameranets, and cannot be accessed from a view of the adjacent wall.
/:cl: