[MIRROR] Material container drops sheets only on object deconstruct & not destroy. #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not destroy. (#793) * Material container drops sheets only on object deconstruct & not destroy. (#81290) ## About The Pull Request - Fixes #81289 It has nothing to do with `dump_contents()` but with the material container that drops its materials on `Destroy()` causing side effects. Now it only drops sheets when an object is deconstructed but not destroyed. For this to work properly on all instances we have to ensure `deconstruct()` is not overridden at least on machines for now, so they can send `COMSIG_OBJ_DECONSTRUCT` signal. That comes in the next PR ## Changelog :cl: fix: deleting objects with local material storage(autolathe, drone dispenser etc) no longer drops sheets, they only drop materials when deconstructed /:cl: * Material container drops sheets only on object deconstruct & not destroy. --------- Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#793
Original PR: tgstation/tgstation#81290
About The Pull Request
It has nothing to do with
dump_contents()but with the material container that drops its materials onDestroy()causing side effects. Now it only drops sheets when an object is deconstructed but not destroyed.For this to work properly on all instances we have to ensure
deconstruct()is not overridden at least on machines for now, so they can sendCOMSIG_OBJ_DECONSTRUCTsignal. That comes in the next PRChangelog
🆑 SyncIt21
fix: deleting objects with local material storage(autolathe, drone dispenser etc) no longer drops sheets, they only drop materials when deconstructed
/:cl: