Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Implements rgb2num, uses it to replace all our manual rgb reading. Redoes HSV management #1881

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#729
Original PR: tgstation/tgstation#81182

About The Pull Request

Converts all manual extraction of rbg with rgb2num. It's just better

Yanks out old HSV management, replaces it with list stuff

There's this old lummy era clunky code that passed HSV as text

We can now cleanly replace it with passing hsv as lists from a rgb2hsv
proc

So let's just do that.

Also, cleans up spraytan code (and ethereal lighting)

Why It's Good For The Game

Code better

…ading. Redoes HSV management (#729)

* Implements rgb2num, uses it to replace all our manual rgb reading. Redoes HSV management

* Merge conflicts, fixing diffs, modular updates

* Some additional modular updates

* Update lighting.dm

* This should also work?

* Removing as much of the copy pasted lighting code as possible, refactoring it, and fixing a bug that would cause an empty light color

* Update light.dm

* Revert "Update light.dm"

This reverts commit 75d4115ecbd99c5c2a251ddf487bb8aab751e66d.

* This is the actual cause of the whitespace bug

Stupid

* Don't need this check really

Stupid

---------

Co-authored-by: LemonInTheDark <[email protected]>
Co-authored-by: Mal <[email protected]>
@Iajret Iajret merged commit 6f3de1e into master Feb 9, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-729 branch February 9, 2024 16:42
Iajret pushed a commit that referenced this pull request Apr 9, 2024
…1881)

* [NO GBP] Reagent grinders display reagents on examination (#82535)

## About The Pull Request
- Fixes #82531

Somehow omitted this during the general maintenance thing

## Changelog
:cl:
fix: Reagent grinders display reagents of its beaker on examination
/:cl:

* [NO GBP] Reagent grinders display reagents on examination

---------

Co-authored-by: SyncIt21 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants