[MIRROR] Adds Custom Announcement Dividers #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds Custom Announcement Dividers * Skyrat custom announcements --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: lessthanthree <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Oct 20, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 6, 2024
…ants of some missing them (#189) * split \mob\mod.dmi into a mod_clothing and mod_module file as TG has * it'd probably help for the module file to link to the module dmi * rename this icon state since the test failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24471
Original PR: tgstation/tgstation#79071
This ports a whole bunch of various PRs and commits from https://github.com/effigy-se/effigy-se , with heavy refactoring to keep it fresh for /tg/'s code standards.
About The Pull Request
The whole slew of announcement touchups lately (as in #78995 (37db1ecbf8d7ceeaeb134c56b403339555f44cea) / #79052 (12308dbd3dae702a1c7b9f7f80d7859aea085c82)) have made me realize how much this stuff sucks. The author of these new spans was advertising these in coding general, so I sat down and coded it. Look at the spans, they're much nicer than what we had going on:
(ignore the capitalized alert status names, this was removed)
Dark Mode
Light Mode
This PR also features
<br>dogshit everywhere!Why It's Good For The Game
In the same vein of adding examine blocks (#67937 (b864589522f4f14183270a62dbea3df8028d2eb6)) because old examinations tended to blend in with the chat and everything chat-wise used to suck really hard- I think this is a really nice way to draw attention to announcements in the chat box without needing a shit load of line breaks that just really look ugly and have no real consistency. You can look at the PRs/commits I linked above for an idea of just how ugly it could be getting.
I haven't audited every announcement in this PR, we can tweak this down the line.
Changelog
🆑 LT3, san7890
add: Announcements have gotten a fresh coat of paint! They should be popping with splendid new colors and should have a lot less ugly linebreaks, while still managing to keep your attention at the screen.
/:cl:
I know we didn't need to port all the CSS themes but I added them anyways in case admins wanna have some fun.
There can probably be more code improvements, just figured I'd crack it out while I had time.
The colors also seem fine, let me know if we need more redness or something. It's okay for stuff to be toned down a bit imo, but that should be done after a hot second.