[MIRROR] Refactors fire overlays once again to make it not get stuck so often #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so often (#877) * Refactors fire overlays once again to make it not get stuck so often * Fix conflict I went back about 20-30 prs on tg to figure out where we missed something but I am not fully sure when this was last changed apart from 21 months ago which matches up with TG * Unchanged files, fixed * Hi yes, I like my robotic XENOS --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 11, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Rephrases advisory level descriptions (#82585)
## About The Pull Request
Some of the station alert descriptions contained grammatical errors.
This PR corrects some word choice, punctuation, and grammar mistakes as
well as editing some sections for clarity. For example, Pulsar Star's
current warning
> "Your sector's advisory level is Pulsar Star. A large unknown
electromagnetic field has stormed through nearby surveillance equipment.
No surveillance data has been able to be obtained showing no credible
threats to Nanotrasen assets within the Spinward Sector. The Department
advises maintaining high alert against potential threats, regardless of
a lack of information."
has been changed to
> "Your sector's advisory level is Pulsar Star. A large, unknown
electromagnetic field has stormed through nearby surveillance equipment
causing major data loss. Partial data was recovered and showed no
credible threats to Nanotrasen assets within the Spinward Sector;
however, the Department of Intelligence advises maintaining high alert
against potential threats due to the lack of complete data."
## Why It's Good For The Game
Readability is important
## Changelog
:cl:
spellcheck: grammar fixes in the roundstart advisory warnings
/:cl:
---------
Co-authored-by: MrMelbert <[email protected]>
* Rephrases advisory level descriptions
---------
Co-authored-by: Horatio22 <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#877
Original PR: tgstation/tgstation#81367
About The Pull Request
Maybe finally fixes #77701
A big reason why this kept happening is because fire uses standing overlays. But fire isn't managed by mobs anymore. Meaning in some situations, fire can cease to exist but the overlay can still be on the mob. So it gets stuck.
So like, why use standing overlays anymore? We can just hook
update_overlayssignal.Isn't that neat.
Changelog
🆑 Melbert
refactor: Fire effects get added to mobs in a different way now. Maybe it will get stuck less. Report any oddities.
/:cl: