[MIRROR] Venus Human Traps have an orbit menu category, recieve antag datum on spawn #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… datum on spawn (#935) * Venus Human Traps have an orbit menu category, recieve antag datum on spawn (#81411) ## About The Pull Request Venus Human Traps now have their own category in the orbit menu. It is a pleasant shade of green, just like vines are.  Venus Human Traps are also now given their antagonist datum upon spawning from a flower. The datum isn't really anything special but it's consistent with the other antag spawners. This also makes the spawner piece of the VHT flower bud invisible. It's an abstract object meant to handle the logic for spawning, and only the structure should be visible. This currently manifests as there being two, identical flower buds on the same tile when a flower bud spawns. I did not want to get into untangling the two objects in this PR. ## Why It's Good For The Game Venus human traps being lumped in with the humans in the "Alive" menu is WEIRD. Now ghosts can give a gigantic vine infestation the attention it truly deserves. Fixes a minor visual incongruity found while doing all this. ## Changelog :cl: Rhials qol: Venus Human Traps are now visible in the orbit menu. Cool! fix: Spawning as a Venus Human Trap now properly gives you an antag datum/objective. fix: Venus human trap flowers no longer have a second, identical flower under themselves. /:cl: * Venus Human Traps have an orbit menu category, recieve antag datum on spawn --------- Co-authored-by: Rhials <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 13, 2024
Iajret
pushed a commit
that referenced
this pull request
May 8, 2024
…ks, gives taur legs names, etc. (#1954) * atomize * dwa' * why isnt it publishing * womp * i am stupid * suffix, to avoid confusion * Apply suggestions from code review Co-authored-by: GoldenAlpharex <[email protected]> * manual review --------- Co-authored-by: GoldenAlpharex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#935
Original PR: tgstation/tgstation#81411
About The Pull Request
Venus Human Traps now have their own category in the orbit menu. It is a pleasant shade of green, just like vines are.
Venus Human Traps are also now given their antagonist datum upon spawning from a flower. The datum isn't really anything special but it's consistent with the other antag spawners.
This also makes the spawner piece of the VHT flower bud invisible. It's an abstract object meant to handle the logic for spawning, and only the structure should be visible. This currently manifests as there being two, identical flower buds on the same tile when a flower bud spawns. I did not want to get into untangling the two objects in this PR.
Why It's Good For The Game
Venus human traps being lumped in with the humans in the "Alive" menu is WEIRD. Now ghosts can give a gigantic vine infestation the attention it truly deserves.
Fixes a minor visual incongruity found while doing all this.
Changelog
🆑 Rhials
qol: Venus Human Traps are now visible in the orbit menu. Cool!
fix: Spawning as a Venus Human Trap now properly gives you an antag datum/objective.
fix: Venus human trap flowers no longer have a second, identical flower under themselves.
/:cl: