Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Mafia can be played on your PDA #199

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24485
Original PR: tgstation/tgstation#78576

About The Pull Request

Mafia is now friggin playable from the PDA, I also changed other stuff too

  • You can't use abilities on dead people if you're not supposed to (cant kill the same person over and over)
  • Changelings cant kill other Changelings
  • Changelings can now only talk to eachother at night, rather than using :j
  • Everyone starts spawned in the center of the map, since people playing on PDA can't move their characters. This is so everyone can hear PDA users in person, as I don't want the chat log to be mandatory.

To do this, all messages you are meant to be able to see, is now logged for you to see in your Mafia panel. This essentially means that people playing through the PDA get a downgraded version of it, but I don't know how much larger I want this UI to be.

Playing Mafia through the PDA will not tell you of other players ahead of time when signing up (as it shows ckeys + pdas), but they can see the names in-game. Unfortunately this means we'll have to remove your customization coming with you, to prevent using it to tell who is dead in round.

Things I am missing

  • Program overlays on PDA/Laptop/Computer
  • Icon for the app's header while a game is active

I'm not a spriter and can't make either of these

This is the new UI
image

I also fixed alert calls for PDAs and stuff
image

and removed the X at the top on computers since they had no battery
image

Looks a little better now hopefully 👍

Why It's Good For The Game

  • The current Arcade app sucks, and is a solo game. This is much more entertaining and you can talk to others in it, which is swag as fuck.
  • There's a larger potential playerbase for the Minigame making it more likely to be played.
  • Sets groundwork for a better version of Adds the Coroner (to Mafia) tgstation/tgstation#75879
  • Adds more suspense and teamwork in the minigame.

Changelog

🆑 JohnFulpWillard, sprites by CoiledLamb
add: You can now play Mafia on your PDA.
balance: Mafia changelings can now only talk to eachother during the night.
fix: Mafia abilities can't be repeatedly used on people.
/:cl:

* Mafia can be played on your PDA (#78576)

## About The Pull Request

Mafia is now friggin playable from the PDA, I also changed other stuff
too

- You can't use abilities on dead people if you're not supposed to (cant
kill the same person over and over)
- Changelings cant kill other Changelings
- Changelings can now only talk to eachother at night, rather than using
:j
- Everyone starts spawned in the center of the map, since people playing
on PDA can't move their characters. This is so everyone can hear PDA
users in person, as I don't want the chat log to be mandatory.

To do this, all messages you are meant to be able to see, is now logged
for you to see in your Mafia panel. This essentially means that people
playing through the PDA get a downgraded version of it, but I don't know
how much larger I want this UI to be.

Playing Mafia through the PDA will not tell you of other players ahead
of time when signing up (as it shows ckeys + pdas), but they can see the
names in-game. Unfortunately this means we'll have to remove your
customization coming with you, to prevent using it to tell who is dead
in round.

Things I am missing
- Program overlays on PDA/Laptop/Computer
- Icon for the app's header while a game is active

I'm not a spriter and can't make either of these

This is the new UI

![image](https://github.com/tgstation/tgstation/assets/53777086/7cf503d9-b2e2-4127-874a-acad6425d649)

I also fixed alert calls for PDAs and stuff

![image](https://github.com/tgstation/tgstation/assets/53777086/e09b2e5e-b9e7-43ae-9273-c168e9c8e642)

and removed the X at the top on computers since they had no battery

![image](https://github.com/tgstation/tgstation/assets/53777086/d3dd8307-805c-4aba-be5e-4c24a0bdcb91)

Looks a little better now hopefully 👍

## Why It's Good For The Game

- The current Arcade app sucks, and is a solo game. This is much more
entertaining and you can talk to others in it, which is swag as fuck.
- There's a larger potential playerbase for the Minigame making it more
likely to be played.
- Sets groundwork for a better version of
tgstation/tgstation#75879
- Adds more suspense and teamwork in the minigame.

## Changelog

:cl: JohnFulpWillard, sprites by CoiledLamb
add: You can now play Mafia on your PDA.
balance: Mafia changelings can now only talk to eachother during the
night.
fix: Mafia abilities can't be repeatedly used on people.
/:cl:

* Mafia can be played on your PDA

---------

Co-authored-by: John Willard <[email protected]>
@Iajret Iajret merged commit f226883 into master Oct 21, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-24485 branch October 21, 2023 23:36
AnywayFarus added a commit that referenced this pull request Oct 21, 2023
Iajret pushed a commit that referenced this pull request Jan 3, 2024
* Disallow powergamey quirk combos

* Airlocks no longer inflict brain damage on oversized characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants